Don't spawn a channel for ProfilerChan when profiling is off #40823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
jdm
requested changes
Nov 22, 2025
Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
jdm
approved these changes
Nov 23, 2025
Member
jdm
left a comment
There was a problem hiding this comment.
Thank you! One less thread is another nice improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProfilerChan now takes an Option<> in order to avoid spawning a channel when unnecessary.
Testing: Manual (-p and --profiler-trace-path options still work with these changes).
Fixes: #40810