Skip to content

Conversation

@freyacodes
Copy link
Contributor

This fixes an incompatibility between mesa and wayland 1.23.x which causes a panic

Testing: ./mach test-unit

NB: These tests failed. I have no way of verifying if they failed because of this change

     Summary [   5.146s] 814 tests run: 793 passed (1 slow), 21 failed, 0 skipped
        FAIL [   0.010s] compositing_traits rendering_context::test::test_read_pixels
        FAIL [   0.029s] libservo::webview test_confirm_dialog
        FAIL [   0.035s] libservo::webview test_can_go_forward_and_can_go_back
        FAIL [   0.036s] libservo::servo test_simple_start_and_stop_servo
        FAIL [   0.040s] libservo::multiprocess test_multiprocess_preference_observer
        FAIL [   0.039s] libservo::webview test_alert_dialog
        FAIL [   0.032s] libservo::webview test_control_show_and_hide
        FAIL [   0.031s] libservo::webview test_create_webview_and_immediately_drop_webview_before_shutdown
        FAIL [   0.050s] libservo::webview test_contextual_context_menu_items
        FAIL [   0.028s] libservo::webview test_cursor_change
        FAIL [   0.051s] libservo::webview test_create_webview
        FAIL [   0.030s] libservo::webview test_evaluate_javascript_panic
        FAIL [   0.027s] libservo::webview test_prompt_dialog
        FAIL [   0.031s] libservo::webview test_evaluate_javascript_basic
        FAIL [   0.030s] libservo::webview test_negative_resize_to_request
        FAIL [   0.029s] libservo::webview test_page_zoom
        FAIL [   0.034s] libservo::webview test_resize_webview_zero
        FAIL [   0.033s] libservo::webview test_show_and_hide_ime
        FAIL [   0.027s] libservo::webview test_theme_change
        FAIL [   0.031s] libservo::webview test_simple_context_menu
        FAIL [   0.031s] libservo::webview test_viewport_meta_tag_initial_zoom
error: test run failed

This fixes an incompatibility with mesa and wayland 1.23.x causing a panic

Signed-off-by: Freya Arbjerg <git@arbjerg.dev>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 22, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 23, 2025
@yezhizhen yezhizhen added this pull request to the merge queue Nov 23, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 23, 2025
Merged via the queue into servo:main with commit 7bdfb4b Nov 23, 2025
35 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 23, 2025
@freyacodes freyacodes deleted the nixpkgs-update branch November 23, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants