servoshell: Remove code duplication in EventsLoop and rename to ServoEventLoop
#40815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukilan
approved these changes
Nov 22, 2025
| } | ||
| impl HeadedEventLoopWaker { | ||
| fn new(events_loop: &winit::event_loop::EventLoop<AppEvent>) -> HeadedEventLoopWaker { | ||
| fn new(events_loop: &EventLoop<AppEvent>) -> HeadedEventLoopWaker { |
Member
There was a problem hiding this comment.
Suggested change
| fn new(events_loop: &EventLoop<AppEvent>) -> HeadedEventLoopWaker { | |
| fn new(event_loop: &EventLoop<AppEvent>) -> HeadedEventLoopWaker { |
fc5f79e to
91e03c2
Compare
…rvoEventLoop` It used to be that the winit event loop for different platforms was initialized differently. That isn't the case any longer, so we do not need platform-specific code here. In addition, I think that the slightly-odd `EventsLoop` name was chosen to not conflict with winit's `EventLoop`. Instead I've renamed this to `ServoEventLoop` and removed one level of nesting in the data structure, which simplifies things a bit. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
91e03c2 to
6a18a72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be that the winit event loop for different platforms was
initialized differently. That isn't the case any longer, so we do not
need platform-specific code here.
In addition, I think that the slightly-odd
EventsLoopname was chosento not conflict with winit's
EventLoop. Instead I've renamed this toServoShellEventLoopand removed one level of nesting in the data structure,which simplifies things a bit.
Testing: This should not change behavior, so the WPT should cover it.