Skip to content

Conversation

@kkoyung
Copy link
Member

@kkoyung kkoyung commented Nov 22, 2025

The enum variant ExportedKey::Raw(Vec<u8>) is actually used when a key is exported in "raw", "spki" or "pkcs8" format. Naming it as Raw could be confusing.

This patch renames ExportedKey::Raw to ExportedKey::Bytes.

Testing: No behavioral change. Existing tests suffice.

The enum variant `ExportedKey::Raw(Vec<u8>)` is actually used when a key
is exported in "raw", "spki" or "pkcs8" format. Naming it as `Raw` could
be confusing.

This patch renames `ExportedKey::Raw` to `ExportedKey::Bytes`.

Testing: No behavioral change. Existing tests suffice.

Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
@kkoyung kkoyung requested a review from gterzian as a code owner November 22, 2025 05:30
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 22, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 22, 2025
@yezhizhen yezhizhen enabled auto-merge November 22, 2025 05:33
@yezhizhen yezhizhen added this pull request to the merge queue Nov 22, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 22, 2025
Merged via the queue into servo:main with commit f804216 Nov 22, 2025
35 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 22, 2025
@kkoyung kkoyung deleted the exportedkey-bytes branch November 22, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants