Skip to content

Conversation

@yerke
Copy link
Contributor

@yerke yerke commented Nov 22, 2025

servoshell: hide tab bar in full screen mode

Testing: Tested manually.
Fixes: #40789

Before:
Screenshot 2025-11-21 at 9 05 09 PM

After:
Screenshot 2025-11-21 at 9 00 35 PM

Signed-off-by: Yerkebulan Tulibergenov <yerkebulan@gmail.com>
@yerke yerke marked this pull request as ready for review November 22, 2025 05:16
@yerke yerke requested a review from atbrakhi as a code owner November 22, 2025 05:16
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 22, 2025
@jdm
Copy link
Member

jdm commented Nov 22, 2025

Since we don't have any way to write automated tests for the servoshell UI, this looks good to go.

Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 22, 2025
@jdm jdm added this pull request to the merge queue Nov 22, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 22, 2025
Merged via the queue into servo:main with commit db540e3 Nov 22, 2025
35 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 22, 2025
@yerke yerke deleted the fix-40789 branch November 22, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabbar shouldn't be visible when video is fullscreen

3 participants