Skip to content

Conversation

@webbeef
Copy link
Contributor

@webbeef webbeef commented Nov 22, 2025

Partial fix for #40744

Testing: Refactor covered by existing tests.
Fixes: Contributes to #40744

Partial fix for servo#40744

Signed-off-by: webbeef <me@webbeef.org>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 22, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 22, 2025
@jdm jdm added this pull request to the merge queue Nov 22, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 22, 2025
Merged via the queue into servo:main with commit ab1d762 Nov 22, 2025
35 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 22, 2025
@Narfinger
Copy link
Contributor

Narfinger commented Nov 24, 2025

This has performance implications, so I would like somebody to look at it first.
https://blog.cuongle.dev/p/inside-rusts-std-and-parking-lot-mutexes-who-win says that for light contention and small critical sections std is faster. This both holds imho for the networking code.
Should we revert this change? @jdm @webbeef
There is probably a different way to have the safety property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants