layout: Preserve cached intrinsic sizes of undamaged descendants #40795

Loirooriol · 2025-11-21T16:13:47Z

We were previously clearing the cached intrinsic inline sizes when the element, an ancestor, or a child had relayout damage. However, intrinsic sizes don't depend on ancestors for the most part, so now we will only clear the cache if the relayout damage is in the element or a descendant.

Testing: Not needed, no change in behavior

github-actions · 2025-11-21T16:14:04Z

🔨 Triggering try run (#19576473258) for Linux (WPT)

Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Oriol Brufau <obrufau@igalia.com>

github-actions · 2025-11-21T16:43:29Z

Test results for linux-wpt from try job (#19576473258):

Flaky unexpected result (41)

OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
OK /_mozilla/webxr/create_session.https.html
- FAIL [expected PASS] subtest: create_session
```
can't access property "simulateDeviceConnection", navigator.xr.test is undefined
```

OK /_mozilla/webxr/obtain_frame.https.html

FAIL [expected PASS] subtest: obtain_frame

promise_test: Unhandled rejection with value: object "TypeError: can't access property "simulateDeviceConnection", navigator.xr.test is undefined"

CRASH [expected OK] /_webgl/conformance/more/conformance/quickCheckAPI-C.html
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- FAIL [expected PASS] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
```
assert_unreached: The IFrame should have been blocked (or cross-origin). It wasn't. Reached unreachable code
```
TIMEOUT /content-security-policy/inheritance/location-reload.html (#38983)
- PASS [expected FAIL] subtest: location.reload() of empty iframe.

OK [expected TIMEOUT] /cookiestore/httponly_cookies.https.window.html (#40697)

FAIL [expected TIMEOUT] subtest: HttpOnly cookies are not observed

assert_equals: HttpOnly cookie we wrote using HTTP in cookie jar is invisible to script expected (undefined) undefined but got (string) "cspViolationReportCookie1=1"

FAIL [expected NOTRUN] subtest: HttpOnly cookies can not be set by document.cookie

assert_equals: Trying to store an HttpOnly cookie with document.cookie fails expected "cookie1=value1; cookie3=value3" but got "HTTPONLY-cookie=value; cookie1=value1; cookie3=value3"

FAIL [expected NOTRUN] subtest: HttpOnly cookies can not be set by CookieStore

assert_equals: httpOnly is not an option for CookieStore.set() expected "cookie1=value1; cookie2=value2; cookie3=value3" but got "HTTPONLY-cookie=value; cookie1=value1; cookie2=value2; cookie3=value3"

FAIL [expected NOTRUN] subtest: HttpOnly cookies are not deleted/overwritten

assert_equals: HttpOnly cookie is not deleted expected (string) "HTTPONLY-cookie=value" but got (undefined) undefined

CRASH [expected OK] /credential-management/idlharness.https.window.html
FAIL [expected PASS] /css/css-backgrounds/background-size-042.html
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted math (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai) (drawing text in a canvas)
TIMEOUT [expected FAIL] /css/css-grid/abspos/positioned-grid-items-017.html
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - empty name exists
CRASH [expected FAIL] /dom/xslt/large-cdata.html (#38029)
OK /fetch/content-length/api-and-duplicate-headers.any.html (#35873)
- FAIL [expected PASS] subtest: fetch() and duplicate Content-Length/Content-Type headers
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /fetch/fetch-later/permissions-policy/deferred-fetch-allowed-by-permissions-policy.https.window.html (#40478)
- FAIL [expected PASS] subtest: Permissions policy header: "deferred-fetch=*" allows fetchLater() in the top-level document.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
OK [expected CRASH] /fetch/metadata/generated/element-iframe.https.sub.html (#40341)
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
ERROR [expected TIMEOUT] /html/browsers/browsing-the-web/history-traversal/pageswap/pageswap-initial-navigation.html (#40387)
OK /html/browsers/browsing-the-web/navigating-across-documents/009.html (#24456)
- PASS [expected FAIL] subtest: Link with onclick form submit to javascript url with document.write and href navigation

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
- PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt;
```
- TIMEOUT [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
```
Test timed out
```
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html (#39694)
- PASS [expected FAIL] subtest: Meta refresh is blocked by the allow-scripts sandbox flag at its creation time, not when refresh comes due
ERROR [expected OK] /html/semantics/embedded-content/media-elements/event_timeupdate_noautoplay.html (#25046)
OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
- PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic test (formdata event)
```
assert_equals: expected "basic=test\r\n" but got ""
```
- FAIL [expected PASS] subtest: text/plain: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt\r\n" but got ""
```
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic test (formdata event)
```
assert_equals: expected "basic=test" but got ""
```
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt" but got ""
```
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: single quote in filename (normal form)
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730, #39631)

OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)

FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler

assert_array_equals: expected property 1 to be "Script #1 ran" but got "Script #3 ran" (expected array ["Script #2 ran", "Script #1 ran", "Script #3 ran", "Script #4 ran"] got ["Script #2 ran", "Script #3 ran", "Script #4 ran", "Script #1 ran"])

OK [expected ERROR] /html/user-activation/no-activation-thru-escape-key.html (#40343)
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
- PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
- PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
CRASH [expected OK] /pointerevents/pointerevent_multiple_pointerover_no_pointer_movement.html
OK /service-workers/service-worker/fetch-event.https.html (#36234)
- PASS [expected FAIL] subtest: Service Worker falls back to network in fetch event with POST form
CRASH [expected OK] /trusted-types/Node-multiple-arguments.html
CRASH [expected OK] /trusted-types/eval-function-constructor.html
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
TIMEOUT /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- TIMEOUT [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
CRASH [expected TIMEOUT] /wasm/webapi/empty-body.any.worker.html
CRASH [expected OK] /webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source.html

Stable unexpected results that are known to be intermittent (21)

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/transaction-deactivation-timing.any.html (#38772)
- PASS [expected FAIL] subtest: New transactions are deactivated before next task
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /fetch/fetch-later/new-window.https.window.html (#32036)
- FAIL [expected PASS] subtest: A same-origin window[target=''][features=''] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
- FAIL [expected PASS] subtest: A same-origin window[target=''][features='popup'] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
- FAIL [expected PASS] subtest: A same-origin window[target='_blank'][features=''] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
- FAIL [expected PASS] subtest: A same-origin window[target='_blank'][features='popup'] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Cross-site
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- FAIL [expected PASS] subtest: sec-fetch-site - Same site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- FAIL [expected PASS] subtest: sec-fetch-site - Same-Origin -> Same-Site -> Same-Origin redirect, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- FAIL [expected PASS] subtest: sec-fetch-site - Same-Origin -> Cross-Site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Site -> Cross-Site, no attributes
- FAIL [expected PASS] subtest: sec-fetch-mode - attributes: crossorigin
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-mode - attributes: crossorigin=anonymous
- FAIL [expected PASS] subtest: sec-fetch-mode - attributes: crossorigin=use-credentials
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-dest - no attributes
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Same site, no attributes
OK /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-mode - Not sent to non-trustworthy same-origin destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-mode - Not sent to non-trustworthy cross-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-dest - Not sent to non-trustworthy cross-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-user - Not sent to non-trustworthy cross-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination, no attributes
TIMEOUT [expected CRASH] /fetch/metadata/window-open.https.sub.html (#40339)
OK [expected ERROR] /focus/focus-event-after-switching-iframes.sub.html (#40368)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
ERROR [expected OK] /html/infrastructure/common-dom-interfaces/collections/domstringlist.html (#40665)
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- FAIL [expected TIMEOUT] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
assert_equals: expected "DIV" but got "BODY"
```
OK [expected CRASH] /html/semantics/embedded-content/media-elements/preserves-pitch.html (#40352)
- FAIL [expected PASS] subtest: Test that preservesPitch is present and unprefixed.
```
assert_true: expected true got false
```
- FAIL [expected PASS] subtest: Test that preservesPitch is on by default
```
assert_true: expected true got undefined
```
- FAIL [expected PASS] subtest: Speed-ups should change the pitch when preservesPitch=false
```
assert_approx_equals: The actual pitch should be close to the expected pitch. expected 880 +/- 132 but got 431.0850439882698
```
- FAIL [expected PASS] subtest: Slow-downs should change the pitch when preservesPitch=false
```
assert_approx_equals: The actual pitch should be close to the expected pitch. expected 220 +/- 33 but got 431.0850439882698
```

OK /html/webappapis/user-prompts/print-during-unload.html (#35944)

FAIL [expected PASS] subtest: print() during unload

assert_array_equals: expected property 1 to be "destination" but got "error: window.print is not a function" (expected array ["start", "destination"] got ["start", "error: window.print is not a function"])

CRASH [expected OK] /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html (#40418)
OK /reporting/same-origin-same-site-credentials.https.sub.html (#40479)
- FAIL [expected PASS] subtest: Reporting endpoints received credentials.
```
assert_equals: No additional cookies were received expected 4 but got 5
```
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- TIMEOUT [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)

github-actions · 2025-11-21T16:43:38Z

✨ Try run (#19576473258) succeeded.

Loirooriol added A-layout/2020 https://github.com/servo/servo/wiki/Layout-2020 T-linux-wpt Do a try run of the WPT labels Nov 21, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Nov 21, 2025

layout: Preserve cached intrinsic sizes of undamaged descendants

036bf7c

Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Oriol Brufau <obrufau@igalia.com>

Loirooriol force-pushed the preserve-inline_content_size branch from ff55d42 to 036bf7c Compare November 21, 2025 17:01

Loirooriol marked this pull request as ready for review November 21, 2025 17:08

Loirooriol requested a review from mrobinson as a code owner November 21, 2025 17:08

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 21, 2025

mrobinson approved these changes Nov 21, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 21, 2025

Loirooriol added this pull request to the merge queue Nov 21, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 21, 2025

Loirooriol mentioned this pull request Nov 21, 2025

layout: Preserve cached layout results of undamaged descendants #40797

Merged

Loirooriol removed this pull request from the merge queue due to a manual request Nov 21, 2025

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 21, 2025

Loirooriol added this pull request to the merge queue Nov 21, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 21, 2025

Merged via the queue into servo:main with commit 5ed9ce9 Nov 21, 2025
39 checks passed

Loirooriol deleted the preserve-inline_content_size branch November 21, 2025 19:22

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

layout: Preserve cached intrinsic sizes of undamaged descendants #40795

layout: Preserve cached intrinsic sizes of undamaged descendants #40795

Uh oh!

Loirooriol commented Nov 21, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

layout: Preserve cached intrinsic sizes of undamaged descendants #40795

layout: Preserve cached intrinsic sizes of undamaged descendants #40795

Uh oh!

Conversation

Loirooriol commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Loirooriol commented Nov 21, 2025 •

edited

Loading