-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
html: Update MediaSession setPositionState method
#40793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TimvdLippe
merged 1 commit into
servo:main
from
tharkum:html-media-session-set-position-state
Nov 24, 2025
Merged
html: Update MediaSession setPositionState method
#40793
TimvdLippe
merged 1 commit into
servo:main
from
tharkum:html-media-session-set-position-state
Nov 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#19573599844) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19573599844): Flaky unexpected result (33)
Stable unexpected results that are known to be intermittent (28)
Stable unexpected results (1)
|
|
|
jdm
approved these changes
Nov 22, 2025
2c31fda to
62c25ac
Compare
setPositionState methodsetPositionState method
The MediaSession `setPositionState` method should only update the position state and propagate it to the platform media session UI controller and shouldn't change somehow the properties of the media element directly (duration, playback rate or position). See https://w3c.github.io/mediasession/#dom-mediasession-setpositionstate Testing: Improvements in the following tests - /mediasession/positionstate.html The media session UI functionality is implemented for Android and didn't test due lack of testing sample. Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>
62c25ac to
99b9f4e
Compare
|
🔨 Triggering try run (#19624797071) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19624797071): Flaky unexpected result (43)
Stable unexpected results that are known to be intermittent (20)
|
|
✨ Try run (#19624797071) succeeded. |
d76f8b9 to
99b9f4e
Compare
TimvdLippe
approved these changes
Nov 24, 2025
Contributor
Author
|
Looks like internal CI build failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MediaSession
setPositionStatemethod should only update the position state and propagate it to the platform media session UI controller and shouldn't change somehow the properties of the media element directly (duration, playback rate or position).See https://w3c.github.io/mediasession/#dom-mediasession-setpositionstate
Testing: Improvements in the following tests
The media session UI functionality is implemented for Android and didn't test due lack of testing sample.