webdriver: Generalize implicit_wait
#40784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yezhizhen
commented
Nov 21, 2025
Member
Author
yezhizhen
left a comment
There was a problem hiding this comment.
Dear reviewers,
Please just check the first commit. The change is large because of fmt.
Best,
Euclid
mrobinson
reviewed
Nov 21, 2025
components/webdriver_server/lib.rs
Outdated
| where | ||
| T: for<'de> Deserialize<'de> + Serialize, | ||
| callback: impl Fn() -> Result<T, WebDriverError>, | ||
| can_early_return: impl Fn(&T) -> bool, |
Member
There was a problem hiding this comment.
Hrm. Another option here to simplify things is to make it so that callback is callback: impl Fn() -> Result<Option<T>, WebDriverError> and ignore None results. That should give you more flexibility with how you implement the callback because it could also depend on some other kind of state in a more straight-forward way.
Member
Author
There was a problem hiding this comment.
I tried a while. It seems Option is hard in this case. But bool make things easy.
0d2706f to
168469b
Compare
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
168469b to
0e22d4b
Compare
yezhizhen
commented
Nov 21, 2025
| where | ||
| T: for<'de> Deserialize<'de> + Serialize, | ||
| { | ||
| callback: impl Fn() -> Result<(bool, T), WebDriverError>, |
Member
Author
There was a problem hiding this comment.
Putting bool first to avoid potential cloning of T.
mrobinson
approved these changes
Nov 21, 2025
implicit_waitimplicit_wait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to implement implicit wait for other commands, such as send key/element clear/click. But the current trait bound, parameters, and logic are way too tight and specific.
Testing: This should not change existing behaviour.