servoshell: Share WebView management between desktop and EGL platforms #40766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desktop and EGL implementations were maintaining identical WebView collection logic (HashMap, creation order tracking, focus management). Extracted this into a shared WebViewCollection struct in RunningAppStateBase. Both platforms now use the common implementation through trait methods Signed-off-by: atbrakhi <atbrakhi@igalia.com>
|
🔨 Triggering try run (#19544110178) for Linux (WPT), Android, OpenHarmony |
Bencher Report|
Test results for linux-wpt from try job (#19544110178): Flaky unexpected result (47)
Stable unexpected results that are known to be intermittent (21)
|
|
✨ Try run (#19544110178) succeeded. |
1 similar comment
|
✨ Try run (#19544110178) succeeded. |
mrobinson
approved these changes
Nov 21, 2025
Member
mrobinson
left a comment
There was a problem hiding this comment.
Nice. Just a few nits that can be fixed before landing.
| let last_created_webview_id = self.inner().creation_order.last().cloned(); | ||
| let last_created_webview_id = self | ||
| .webview_collection() | ||
| .newest() |
Comment on lines
130
to
134
| impl Default for WebViewCollection { | ||
| fn default() -> Self { | ||
| Self::new() | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
You can remove this entirely as well as WebViewCollection::new() and simply implement #[derive(Default)] on the WebViewCollection.
| self.base().webview_collection.borrow_mut() | ||
| } | ||
|
|
||
| /// Returns all webviews in creation order. |
Member
There was a problem hiding this comment.
Suggested change
| /// Returns all webviews in creation order. | |
| /// Returns all [`WebView`]s in creation order. |
Comment on lines
230
to
231
| /// Gets the "active" webview: the focused webview if there is one, | ||
| /// otherwise the most recently created webview. |
Member
There was a problem hiding this comment.
Suggested change
| /// Gets the "active" webview: the focused webview if there is one, | |
| /// otherwise the most recently created webview. | |
| /// Gets the "active" [`WebView`]: the focused [`WebView`] if there is one, | |
| /// otherwise the most recently created [`WebView`]. |
Comment on lines
237
to
238
| /// Gets the "active" webview, panicking if there is none. | ||
| /// This is a convenience method for platforms that assume there's always an active webview. |
Member
There was a problem hiding this comment.
Suggested change
| /// Gets the "active" webview, panicking if there is none. | |
| /// This is a convenience method for platforms that assume there's always an active webview. | |
| /// Gets the "active" [`WebView`], panicking if there is none. | |
| /// This is a convenience method for platforms that assume there's always an active [`WebView`]. |
Signed-off-by: atbrakhi <atbrakhi@igalia.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desktop and EGL implementations were maintaining identical WebView collection logic (HashMap, creation order tracking, focus management).
Extracted this into a shared WebViewCollection struct in RunningAppStateBase. Both platforms now use the common implementation through trait methods
Testing: Existing tests should cover this change.
Fixes: part of #40530