profiling: Fix missing span enter #40758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't enter the span, then nothing will be traced. Also clean-up some `tracing` feature flag occurence, which is not needed when using the macro from profile_traits. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Member
Author
|
@kongbai1996 I think this is the reason why you weren't seeing Fling in the traces. Can you confirm if it works for you to? |
Contributor
|
It is working properly.
|
Member
Author
|
@yezhizhen sorry for the confusion, I edited the description and added a link to the original PR, which added the trace points - #40629. The PR you linked just added an abstraction, and didn't change anything regarding the behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't enter the span, then nothing will be traced. This was overlooked during review of #40629.
Also clean-up some
tracingfeature flag occurence, which is not needed when using the macro from profile_traits.Testing: Manually tested with
tracing-hitracefeature