Skip to content

Conversation

@sagudev
Copy link
Member

@sagudev sagudev commented Nov 20, 2025

Fixes: #40741

Signed-off-by: Sam <16504129+sagudev@users.noreply.github.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 20, 2025
@sagudev sagudev requested a review from jschwe November 20, 2025 07:19
Copy link
Member

@jschwe jschwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might slow down CI, but I think its definitly worth it to run everything on main, so that we can clearly identify when something started failing.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 20, 2025
@sagudev sagudev added this pull request to the merge queue Nov 20, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 20, 2025
@sagudev
Copy link
Member Author

sagudev commented Nov 20, 2025

It might slow down CI, but I think its definitly worth it to run everything on main, so that we can clearly identify when something started failing.

Yes, that's why fail_fast was not suppose to be on push to begin with, only on MQ.

Merged via the queue into main with commit 10431f4 Nov 20, 2025
35 checks passed
@sagudev sagudev deleted the sagudev-patch-1 branch November 20, 2025 08:20
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All CI jobs on main seem to be cancelled before completion

4 participants