script: Optimize Node::insert #40742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change how the static node list is built to prevent a second iteration of new_nodes - Memoize some invariants of the parent Signed-off-by: webbeef <me@webbeef.org>
mrobinson
approved these changes
Nov 19, 2025
Contributor
Contributor
Author
|
It doesn't solve the exact same case as #37583 so we could still benefit from it (though I don't think it was very successful in practice). It's not sufficient to close #37223 : this improves the DOM side a bit, but we likely also are too slow on the parsing and tree construction. On my machine we're still much slower than Firefox. |
Contributor
Author
|
Some timings for #37223 with this patch:
Even if Firefox has the benefit of a PGO build, the gap is still very large. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing: No wpt regressions: https://github.com/webbeef/servo/actions/runs/19493174678
This improves the
parseFromString()benchmark by ~7% on my machine.