Skip to content

compositor: Share the WebGpuExternalImageMap among all Painters #40737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mukilan merged 1 commit into from
Nov 19, 2025
Merged

compositor: Share the WebGpuExternalImageMap among all Painters #40737

mukilan merged 1 commit into from
Nov 19, 2025

Conversation

@mrobinson
Copy link
Member

@mrobinson mrobinson commented Nov 19, 2025

This is required so that there can be multiple WebGpuExternalImages
for a single Constellation.

Testing: This should not change behavior so is covered by existing tests.

@mrobinson mrobinson requested a review from sagudev as a code owner November 19, 2025 10:27
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 19, 2025
@mrobinson mrobinson added the T-webgpu Do a try run on Linux of the WebGPU CTS label Nov 19, 2025
@github-actions github-actions bot removed the T-webgpu Do a try run on Linux of the WebGPU CTS label Nov 19, 2025
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

🔨 Triggering try run (#19498060377) for Linux (Production, WPT)

@mrobinson mrobinson mentioned this pull request Nov 19, 2025
Closed
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2025

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Test results for linux-wpt from try job (#19498060377):

Flaky unexpected result (9)
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:api,validation,encoding,cmds,clearBuffer:buffer,device_mismatch:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:api,validation,render_pipeline,primitive_state:strip_index_format:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,inversesqrt:abstract_float:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,call,builtin,log2:f16:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,constructor,zero_value:structure:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,unary,bool_conversion:i32:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,validation,expression,call,builtin,pack4x8unorm:must_use:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,validation,expression,call,builtin,pow:invalid_argument:*
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,validation,statement,increment_decrement:var_init_type:*
Stable unexpected results (2)
  • CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:shader,execution,expression,binary,i32_arithmetic:addition_vector_scalar:*
  • FAIL [expected TIMEOUT] /_webgpu/webgpu/webgpu/web_platform/reftests/resize_observer.https.html

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

⚠️ Try run (#19498060377) failed.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 19, 2025
@mrobinson mrobinson added this pull request to the merge queue Nov 19, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 19, 2025
@servo-highfive servo-highfive added S-needs-rebase There are merge conflict errors. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 19, 2025
@mrobinson @mukilan
compositor: Share the WebGpuExternalImageMap among all Painters
74e32d7 
This is required so that there can be multiple `WebGpuExternalImages`
for a single `Constellation`.

Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
@mukilan mukilan force-pushed the share-image-map-among-all-webgpu-image-handlers branch from 61e8d97 to 74e32d7 Compare November 19, 2025 14:42
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-rebase There are merge conflict errors. labels Nov 19, 2025
@mukilan mukilan enabled auto-merge November 19, 2025 14:42
@mukilan mukilan added this pull request to the merge queue Nov 19, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 19, 2025
Merged via the queue into servo:main with commit 613f2ec Nov 19, 2025
35 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sagudev sagudev sagudev approved these changes

Assignees

No one assigned

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrobinson @codecov-commenter @sagudev @mukilan @servo-highfive