Skip to content

Fix RefCell already borrowed panic in HTMLMediaElement::set_audio_renderer #40729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Taym95 merged 1 commit into from
Nov 19, 2025
Merged

Fix RefCell already borrowed panic in HTMLMediaElement::set_audio_renderer #40729

Taym95 merged 1 commit into from
Nov 19, 2025

Conversation

@Taym95
Copy link
Member

@Taym95 Taym95 commented Nov 19, 2025

Fix RefCell already borrowed panic in HTMLMediaElement::set_audio_renderer

Testing: new crash test should pass.
Fixes: #40720

@Taym95 Taym95 requested a review from gterzian as a code owner November 19, 2025 00:14
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 19, 2025
yezhizhen
yezhizhen approved these changes Nov 19, 2025
View reviewed changes
@Taym95 Taym95 force-pushed the fix-RefCell-already-borrowed-panic-in-set_audio_renderer branch from b830702 to d3b859a Compare November 19, 2025 00:20
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 19, 2025
@Taym95
Fix RefCell already borrowed panic in HTMLMediaElement::set_audio_ren…
eb96af5 
…derer

Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
@Taym95 Taym95 force-pushed the fix-RefCell-already-borrowed-panic-in-set_audio_renderer branch from d3b859a to eb96af5 Compare November 19, 2025 00:28
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 19, 2025
@Taym95 Taym95 enabled auto-merge November 19, 2025 00:28
@Taym95 Taym95 added this pull request to the merge queue Nov 19, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 19, 2025
Merged via the queue into servo:main with commit 66a50ad Nov 19, 2025
35 checks passed
@Taym95 Taym95 deleted the fix-RefCell-already-borrowed-panic-in-set_audio_renderer branch November 19, 2025 01:22
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yezhizhen yezhizhen yezhizhen approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees

No one assigned

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

panic: RefCell already borrowed at components/script/dom/html/htmlmediaelement.rs:2116

3 participants

@Taym95 @yezhizhen @servo-highfive