Skip to content

script: Don't allocate when retrieving attribute values for layout #40724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonwuelker merged 1 commit into from
Nov 18, 2025
Merged

script: Don't allocate when retrieving attribute values for layout #40724

simonwuelker merged 1 commit into from
Nov 18, 2025

Conversation

@simonwuelker
Copy link
Contributor

@simonwuelker simonwuelker commented Nov 18, 2025

We end up only calling .iter on these Vecs anyways.

Testing: No behaviour change intended, regressions are covered by existing tests

@simonwuelker
script: Don't allocate when retrieving attribute values for layout
a72e87a 
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 18, 2025
mrobinson
mrobinson approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 18, 2025
@simonwuelker simonwuelker added this pull request to the merge queue Nov 18, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 18, 2025
Merged via the queue into servo:main with commit c5da053 Nov 18, 2025
35 checks passed
@simonwuelker simonwuelker deleted the dont-allocate-for-attrs branch November 18, 2025 19:59
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrobinson mrobinson mrobinson approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simonwuelker @mrobinson @servo-highfive