-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update expectation for media-elements/event_timeupdate_noautoplay.html to PASS by removing .ini
#40714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…autoplay.html` Signed-off-by: WaterWhisperer <waterwhisperer24@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you think it is outdated? The test is still there. And when I run it, still got error as expected most of time.
Also it is still intermittent.
When I run |
Tests can fail on CI, but pass locally and vice versa. This requires doing an investigation into why this is happening in order to fix it. It is very valuable work if you are willing to do it! |
This means it matches the expectation, a.k.a. Error. For me I run until it fails expectation, and get 29/30 pass. But those 29 pass means "ERROR". And the 1 is actually "OK". |
|
🔨 Triggering try run (#19464504204) for Linux (WPT) |
|
What it looks like for me in 2028dab. Each repetition has 4 subtests. It is only OK (failing "ERROR" expectation) for one subtest at third repetition. |
|
Test results for linux-wpt from try job (#19464504204): Flaky unexpected result (41)
Stable unexpected results that are known to be intermittent (22)
|
|
✨ Try run (#19464504204) succeeded. |
|
Oh you may have a point here. It seems to pass in CI. |
|
🔨 Triggering try run (#19465423278) for Linux (WPT) |
|
@yezhizhen Thank you for your detailed explanation! However, I still have some doubts because this result was obtained after I removed |
event_timeupdate_noautoplay.htmlmedia-elements/event_timeupdate_noautoplay.html to PASS
media-elements/event_timeupdate_noautoplay.html to PASSmedia-elements/event_timeupdate_noautoplay.html to PASS
|
Test results for linux-wpt from try job (#19465423278): Flaky unexpected result (43)
Stable unexpected results that are known to be intermittent (30)
|
|
✨ Try run (#19465423278) succeeded. |
media-elements/event_timeupdate_noautoplay.html to PASSmedia-elements/event_timeupdate_noautoplay.html to PASS by removing .ini
yezhizhen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Testing: None
Fixes: #25046