-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
servodriver: Clear cookies between tests. #40709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🔨 Triggering try run (#19458958640) for Linux (WPT) |
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56082) with upstreamable changes. |
|
Test results for linux-wpt from try job (#19458958640): Flaky unexpected result (41)
Stable unexpected results that are known to be intermittent (31)
|
|
✨ Try run (#19458958640) succeeded. |
mrobinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely seems like it is worth a shot. I notice that the code for clearing cookies does not wait synchronously for the clear to complete. This could also add some intermittency to the operation.
|
Actually I don't think this will.do what I expected. I didn't realize this would only clear the cookies for the current origin of the document in the frame that is active. I think we want a custom command that will clear the entire cookie store instead. |
|
🔨 Triggering try run (#19753983339) for Linux (WPT) |
|
I'm going to run a bunch of try jobs and see if any cookie tests appear in the list of known intermittents (ie. they're not fixed by this). |
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56082). |
|
Test results for linux-wpt from try job (#19753983339): Flaky unexpected result (35)
Stable unexpected results that are known to be intermittent (22)
|
|
✨ Try run (#19753983339) succeeded. |
|
🔨 Triggering try run (#19754438402) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19754438402): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (24)
|
|
✨ Try run (#19754438402) succeeded. |
|
This can use another review, since there were many new changes to incorporate the new custom command. |
|
🔨 Triggering try run (#19755292785) for Linux (WPT) |
tests/wpt/tests/tools/wptrunner/wptrunner/executors/executorservodriver.py
Show resolved
Hide resolved
| let (public_resource_threads, private_resource_threads, async_runtime) = new_resource_threads( | ||
| devtools_sender.clone(), | ||
| time_profiler_chan.clone(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we moving these to the caller? Something related to multi-window?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we can access them from the thread that has the Servo instance instead of needing to route to the constellation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want a custom command that will clear the entire cookie store instead.
Indeed. Probably that's why current harness reset many things between subtests, excluding cookie as the standard command is limited.
|
Test results for linux-wpt from try job (#19755292785): Flaky unexpected result (30)
Stable unexpected results that are known to be intermittent (27)
|
|
✨ Try run (#19755292785) succeeded. |
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56082). |
1 similar comment
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56082). |
To ensure that tests that modify cookies but don't finish cleanly don't leave cookie values that interfere with subsequent tests, we need to clear the cookie storage in between each test that's run.
Testing: Can't test the test runner, just have to watch the patterns in our test runs.
Fixes: #40668
Fixes: #40672
Fixes: #40673
Fixes: #40674
Fixes: #40695
Fixes: #40697