Skip to content

indexeddb: Clean shutdown of indexeddb threads/threadpool #40666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yezhizhen merged 2 commits into from
Nov 16, 2025
Merged

indexeddb: Clean shutdown of indexeddb threads/threadpool #40666

yezhizhen merged 2 commits into from
Nov 16, 2025

Conversation

@arihant2math
Copy link
Contributor

@arihant2math arihant2math commented Nov 16, 2025 •
edited
Loading

Clean shutdown of indexeddb.

Testing: Covered by WPT

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 16, 2025
yezhizhen
yezhizhen reviewed Nov 16, 2025
View reviewed changes
Copy link
Member

@yezhizhen yezhizhen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its seems nothing happens with SyncOperation::Exit tho. Can you also help with that?

servo/components/storage/indexeddb/mod.rs

Lines 438 to 441 in 79d9615

SyncOperation::Exit(sender) => {
// FIXME:(rasviitanen) Nothing to do?
let _ = sender.send(());
},

@arihant2math
Update mod.rs
ccd4da1 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math
Copy link
Contributor Author

arihant2math commented Nov 16, 2025

Good point, I've fixed it.

yezhizhen
yezhizhen approved these changes Nov 16, 2025
View reviewed changes
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 16, 2025
@arihant2math @yezhizhen
Update components/storage/indexeddb/mod.rs
05147dc 
Co-authored-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 16, 2025
@yezhizhen yezhizhen enabled auto-merge November 16, 2025 08:11
@yezhizhen yezhizhen added this pull request to the merge queue Nov 16, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 16, 2025
Merged via the queue into servo:main with commit 5aec3ea Nov 16, 2025
35 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yezhizhen yezhizhen Awaiting requested review from yezhizhen

Assignees

No one assigned

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arihant2math @yezhizhen @servo-highfive