-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Implement WindowOrWorkerGlobalScope::reportError
#40654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#19389332721) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19389332721): Flaky unexpected result (42)
Stable unexpected results that are known to be intermittent (29)
Stable unexpected results (1)
|
|
|
577f74f to
e7f7e44
Compare
yezhizhen
reviewed
Nov 16, 2025
Member
yezhizhen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the title? It is very vague right now.
self.reportErrorWindowOrWorkerGlobalScope::reportError
WindowOrWorkerGlobalScope::reportErrorWindowOrWorkerGlobalScope::reportError
yezhizhen
approved these changes
Nov 16, 2025
This web API is alternative API to `throw e`, which is why we can reuse a lot of the existing machinery. The one testcase that isn't passing yet is because it reports an empty `TypeError`. The current logic in `ErrorInfo` only retrieves the message data, but doesn't include the type of the exception. For that, we need to use `(*report)._base.errorNumber` and map that back to the original type codes. However, deferring that to a follow-up as that requires some more work in mozjs. Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
e7f7e44 to
8000dad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This web API is alternative API to
throw e, which is why we can reuse a lot of the existing machinery.The one testcase that isn't passing yet is because it reports an empty
TypeError. The current logic inErrorInfoonly retrieves the message data, but doesn't include the type of the exception. For that, we need to use(*report)._base.errorNumberand map that back to the original type codes. However, deferring that to a follow-up as that requires some more work in mozjs.