libservo: Notify embedder of protocol handler updates #40653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbeef
reviewed
Nov 15, 2025
08cf6fb to
f30a538
Compare
f30a538 to
595c23b
Compare
webbeef
approved these changes
Nov 16, 2025
jdm
approved these changes
Nov 19, 2025
mrobinson
requested changes
Nov 19, 2025
Member
mrobinson
left a comment
There was a problem hiding this comment.
Sorry for the late review! Looks good apart from a couple things:
595c23b to
c8b9512
Compare
TimvdLippe
commented
Nov 19, 2025
c8b9512 to
eacf9c2
Compare
TimvdLippe
commented
Nov 21, 2025
components/servo/tests/webview.rs
Outdated
| .url( | ||
| Url::parse( | ||
| "data:text/html,<!DOCTYPE html><script>\ | ||
| window.navigator.registerProtocolHandler('web+test', 'http://localhost:8000/web/test/');\ |
Contributor
Author
There was a problem hiding this comment.
The test here doesn't work, because registerProtocolHandler can only be called for the same origin. However, none of the webview tests load a URL that has an origin. They call use data:text/html.
How can I refer to local resources so that we spin up a webserver and run that?
All of this is to say, I think instead of having a unit test for this, I rather rely on the WPT tests for these: https://github.com/servo/servo/blob/main/tests/wpt/tests/html/webappapis/system-state-and-capabilities/the-navigator-object/protocol-handler-fragment-nosw.https.html
Member
There was a problem hiding this comment.
Seems reasonable to me! Thanks for looking into this and sorry that it turned out to be a dead end.
FWIW, at some point we likely do need to support running tests from a small local server, but we don't have that built out in the unit tests yet and it seems like too much for this change.
eacf9c2 to
bd34b5a
Compare
048b759 to
bd34b5a
Compare
mrobinson
approved these changes
Nov 21, 2025
Member
mrobinson
left a comment
There was a problem hiding this comment.
Thanks for the changes here!
This implements step 2 of the web-facing API's. Now, the embedder receives a notification whether a webpage wants to register/unregister a protocol handler. They can't do anything with it yet, that's for a follow-up PR. But locally testing shows the following debug log: ``` pid:35180 Requesting to Register for scheme web+test with url https://web-platform.test:8443/html/webappapis/system-state-and-capabilities/the-navigator-object/%s ``` Part of servo#40615 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
bd34b5a to
f549e87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements step 2 of the web-facing API's.
Now, the embedder receives a notification whether
a webpage wants to register/unregister a protocol
handler. They can't do anything with it yet, that's for a follow-up PR. But locally testing shows the
following debug log:
Part of #40615