-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix indexeddb intermitency #40648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indexeddb intermitency #40648
Conversation
|
🔨 Triggering try run (#19385970811) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19385970811): Flaky unexpected result (50)
Stable unexpected results that are known to be intermittent (33)
Stable unexpected results (35)
|
|
|
|
🔨 Triggering try run (#19386386666) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19386386666): Flaky unexpected result (43)
Stable unexpected results that are known to be intermittent (36)
Stable unexpected results (35)
|
|
|
|
Still very intermittent. |
|
Re-opening as I think this shows some promise. |
8c43ba0 to
592a230
Compare
|
🔨 Triggering try run (#19398575562) for Linux (WPT) |
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
592a230 to
a05e3fb
Compare
|
I'm getting a few regressions due to |
|
Test results for linux-wpt from try job (#19398575562): Flaky unexpected result (36)
Stable unexpected results that are known to be intermittent (32)
Stable unexpected results (35)
|
|
|
|
🔨 Triggering try run (#19399007616) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19399007616): Flaky unexpected result (54)
Stable unexpected results that are known to be intermittent (35)
Stable unexpected results (35)
|
|
|
jdm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense!
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
|
🔨 Triggering try run (#19400387410) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19400387410): Flaky unexpected result (53)
Stable unexpected results that are known to be intermittent (25)
Stable unexpected results (1)
|
|
|
|
Expectations updated. |
|
🔨 Triggering try run (#19400706154) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19400706154): Flaky unexpected result (39)
Stable unexpected results that are known to be intermittent (29)
Stable unexpected results (1)
|
|
|
Fixes a major source of intermittency in IndexedDB: the dispatching of the complete event. This ensures that all requests are processed before it is fired.
Fixes: #39162
Fixes: #39221
... and likely many more.