-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
html: Handle new DurationChanged event by <media>
#40644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TimvdLippe
merged 1 commit into
servo:main
from
tharkum:html-media-duration-changed-event
Nov 14, 2025
Merged
html: Handle new DurationChanged event by <media>
#40644
TimvdLippe
merged 1 commit into
servo:main
from
tharkum:html-media-duration-changed-event
Nov 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new event `PlayerEvent::DurationChanged` has been added to the media engine to simplify handling changes in the duration of a media stream (sometimes the duration could be inaccurate or even determined by the media engine with significant delay after the initial metadata was ready). This new event eliminates the need to check conditions for two consecutive `MetadataUpdated` events (the initial metadata and the metadata with the changed duration) during the loading phase. servo-media: - Add new `PlayerEvent::DurationChanged` event (servo/media#461) Testing: No expected changes in test results Fixes: #servo#40626 Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>
|
🔨 Triggering try run (#19365887130) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19365887130): Flaky unexpected result (28)
Stable unexpected results that are known to be intermittent (30)
|
|
✨ Try run (#19365887130) succeeded. |
TimvdLippe
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new event
PlayerEvent::DurationChangedhas been added to the media engine to simplify handling changes in the duration of a media stream (sometimes the duration could be inaccurate or even determined by the media engine with significant delay after the initial metadata was ready).This new event eliminates the need to check conditions for two consecutive
MetadataUpdatedevents (the initial metadata and the metadata with the changed duration) during the loading phase.servo-media:
PlayerEvent::DurationChangedevent (Add newPlayerEvent::DurationChangedevent media#461)Testing: No expected changes in test results
Fixes: #40626