-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
net: Relax the SVG content type detection logic. #40636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The current logic fails when the `Content-Type` header includes the character encoding other parameters like `qs`. Fixes: servo#40630 Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
|
🔨 Triggering try run (#19356477888) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19356477888): Flaky unexpected result (46)
Stable unexpected results that are known to be intermittent (26)
|
|
✨ Try run (#19356477888) succeeded. |
|
Can we add a WPT test for this, given none started passing with this fix? |
Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
19cf19c to
5cc962e
Compare
|
🔨 Triggering try run (#19423234692) for Linux (WPT) |
|
I've added a new WPT test in 5cc962e |
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56050) with upstreamable changes. |
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56050). |
|
Test results for linux-wpt from try job (#19423234692): Flaky unexpected result (35)
Stable unexpected results that are known to be intermittent (27)
Stable unexpected results (2)
|
|
|
yezhizhen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
|
⛔ Failed to properly merge the upstream pull request (web-platform-tests/wpt#56050). Please address any CI issues and try to merge manually. |
The current logic fails when the
Content-Typeheader includes the character encoding other parameters likeqs.Fixes: #40630