-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
layout: Adjust inset-modified containing block to have non-negative size #40628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🔨 Triggering try run (#19351988925) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19351988925): Flaky unexpected result (37)
Stable unexpected results that are known to be intermittent (33)
|
|
✨ Try run (#19351988925) succeeded. |
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56029) with upstreamable changes. |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#56029) title and body. |
e13ecf2 to
7390065
Compare
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#56029) title and body. |
We were storing the computed offsets, deferring the resolution of percentages. Now we will resolve percentages at the beginning. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
7390065 to
e5b6f98
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56029). |
1 similar comment
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56029). |
If the insets of an absolutely positioned box are big enough that the inset-modified containing block (IMCB) would get a negative size, we will now adjust the weaker inset so that the size of the IMCB becomes zero instead.
This affects auto sizes, auto margins, and self-alignment.
This behavior matches Blink for the most part. However, while Blink also ensures a non-negative IMCB size, it doesn't necessarily do so by adjusting the weaker inset, so the alignment may differ.
Blink is fine with adopting this behavior, as resolved by the CSSWG in w3c/csswg-drafts#11478
Testing: Adding new WPT