script: Issue resource timing for stylesheets before the "load" event #40618

mrobinson · 2025-11-13T23:02:35Z

Tests seem to assume that resource timing is available during the "load"
event. Doing so causes some tests to pass and others to fail, which
appear to have been false passes.

This is a preparatory change for asynchronous stylesheet parsing, when
resource timing entires must be added before sending stylesheets to
another thread for parsing.

Testing: This change updates WPT test results.

Tests seem to assume that resource timing is available during the "load" event. Doing so causes some tests to pass and others to fail, which appear to have been false passes. This is a preparatory change for asynchronous stylesheet parsing, when resource timing entires must be added before sending stylesheets to another thread for parsing. Signed-off-by: Martin Robinson <mrobinson@igalia.com>

github-actions · 2025-11-13T23:58:51Z

🔨 Triggering try run (#19349620182) for Linux (WPT)

github-actions · 2025-11-14T00:25:23Z

Test results for linux-wpt from try job (#19349620182):

Flaky unexpected result (44)

OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
ERROR [expected OK] /_mozilla/mozilla/preserve_wrapper_callback.html
OK /_mozilla/webxr/create_session.https.html
- FAIL [expected PASS] subtest: create_session
```
can't access property "simulateDeviceConnection", navigator.xr.test is undefined
```
CRASH [expected OK] /_webgl/conformance/glsl/bugs/conditional-discard-optimization.html
CRASH [expected OK] /_webgl/conformance/ogles/GL/mat/mat_033_to_040.html
CRASH [expected OK] /_webgl/conformance/ogles/GL/mat3/mat3_001_to_006.html
CRASH [expected OK] /_webgl/conformance/ogles/GL/struct/struct_025_to_032.html
CRASH [expected OK] /_webgl/conformance/ogles/GL/struct/struct_033_to_040.html
CRASH [expected OK] /_webgl/conformance/ogles/GL/swizzlers/swizzlers_033_to_040.html
CRASH [expected OK] /_webgl/conformance/ogles/GL/swizzlers/swizzlers_097_to_104.html
CRASH [expected OK] /_webgl/conformance/textures/image_bitmap_from_canvas/tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html
CRASH [expected OK] /_webgl/conformance/textures/misc/texture-npot-video.html
CRASH [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-01.html
CRASH [expected OK] /_webgl/conformance2/context/context-mode.html
CRASH [expected OK] /_webgl/conformance2/programs/get-uniform-indices.html
CRASH [expected ERROR] /_webgl/conformance2/textures/image/tex-3d-rgba4-rgba-unsigned_byte.html

OK [expected TIMEOUT] /cookiestore/httponly_cookies.https.window.html

FAIL [expected TIMEOUT] subtest: HttpOnly cookies are not observed

assert_equals: HttpOnly cookie we wrote using HTTP in cookie jar is invisible to script expected (undefined) undefined but got (string) "cspViolationReportCookie1=1"

FAIL [expected NOTRUN] subtest: HttpOnly cookies can not be set by document.cookie

assert_equals: Trying to store an HttpOnly cookie with document.cookie fails expected "cookie1=value1; cookie3=value3" but got "HTTPONLY-cookie=value; cookie1=value1; cookie3=value3"

FAIL [expected NOTRUN] subtest: HttpOnly cookies can not be set by CookieStore

assert_equals: httpOnly is not an option for CookieStore.set() expected "cookie1=value1; cookie2=value2; cookie3=value3" but got "HTTPONLY-cookie=value; cookie1=value1; cookie2=value2; cookie3=value3"

FAIL [expected NOTRUN] subtest: HttpOnly cookies are not deleted/overwritten

assert_equals: HttpOnly cookie is not deleted expected (string) "HTTPONLY-cookie=value" but got (undefined) undefined

OK /css/CSS2/linebox/inline-negative-margin-001.html

FAIL [expected PASS] subtest: [data-expected-height] 3

assert_equals: 
&lt;div class="w4" data-expected-height="10"&gt;123 &lt;span style="margin-left: -4ch"&gt;1234 &lt;/span&gt;&lt;/div&gt;
height expected 10 but got 20

FAIL [expected PASS] subtest: [data-expected-height] 4

assert_equals: 
&lt;div class="w4" data-expected-height="10"&gt;123 &lt;span style="margin-left: -4ch"&gt;123 &lt;/span&gt;&lt;/div&gt;
height expected 10 but got 20

FAIL [expected PASS] subtest: [data-expected-height] 5

assert_equals: 
&lt;div class="w4" data-expected-height="10"&gt;&lt;img class="w4"&gt;&lt;span style="margin-left: -4ch"&gt;123&lt;/span&gt;&lt;/div&gt;
height expected 10 but got 20

FAIL [expected PASS] subtest: [data-expected-height] 6

assert_equals: 
&lt;div class="w4" data-expected-height="10"&gt;&lt;img class="w5"&gt;&lt;span style="margin-left: -5ch"&gt;123&lt;/span&gt;&lt;/div&gt;
height expected 10 but got 20

OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Null value should submit nothing
- PASS [expected FAIL] subtest: Multiple values - name content attribute is ignored
CRASH [expected FAIL] /dom/xslt/large-cdata.html (#38029)
OK /fetch/fetch-later/permissions-policy/deferred-fetch-allowed-by-permissions-policy.https.window.html (#40478)
- FAIL [expected PASS] subtest: Permissions policy header: "deferred-fetch=*" allows fetchLater() in the top-level document.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-user
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Cross-site
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- FAIL [expected PASS] subtest: Link with onclick navigation and href navigation
```
assert_equals: expected "href" but got "click"
```

OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)

FAIL [expected PASS] subtest: opener of discarded auxiliary browsing context

assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"

CRASH [expected OK] /html/browsers/windows/nested-browsing-contexts/window-top-null.html
CRASH [expected OK] /html/canvas/element/compositing/2d.composite.uncovered.pattern.destination-in.html
CRASH [expected OK] /html/dom/render-blocking/remove-attr-style-keeps-blocking.html
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/src_object_blob.html (#40340)
- TIMEOUT [expected PASS] subtest: HTMLMediaElement.srcObject blob
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
- PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730, #39631)
OK [expected ERROR] /html/semantics/forms/the-input-element/click-user-gesture.html (#40512)
TIMEOUT [expected ERROR] /html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html (#40347)
OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.worker.html (#33909)
- FAIL [expected PASS] subtest: Revoking a blob URL immediately after calling import will not fail
```
promise_test: Unhandled rejection with value: object "TypeError: Dynamic import failed"
```
OK [expected ERROR] /html/user-activation/no-activation-thru-escape-key.html (#40343)
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
CRASH [expected OK] /pointerevents/pointerevent_multiple_pointerover_no_pointer_movement.html
CRASH [expected OK] /trusted-types/eval-function-constructor.html
TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- TIMEOUT [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
CRASH [expected OK] /trusted-types/trusted-types-reporting.html
CRASH [expected OK] /uievents/idlharness.window.html
CRASH [expected OK] /wasm/webapi/esm-integration/worklet-import-source-phase.tentative.https.html
CRASH [expected OK] /webaudio/the-audio-api/the-audiobuffersourcenode-interface/ctor-audiobuffersource.html
CRASH [expected OK] /workers/interfaces/DedicatedWorkerGlobalScope/onmessage.worker.html

Stable unexpected results that are known to be intermittent (29)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
CRASH [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
OK /cookies/value/value-ctl.html (#40338)
- PASS [expected FAIL] subtest: Cookie with %x0 in value is rejected (DOM).
- PASS [expected FAIL] subtest: Cookie with %x1 in value is rejected (DOM).
- PASS [expected FAIL] subtest: Cookie with %x2 in value is rejected (DOM).
- PASS [expected FAIL] subtest: Cookie with %x3 in value is rejected (DOM).
- PASS [expected FAIL] subtest: Cookie with %x4 in value is rejected (DOM).
- PASS [expected FAIL] subtest: Cookie with %x5 in value is rejected (DOM).
- PASS [expected FAIL] subtest: Cookie with %x6 in value is rejected (DOM).
- PASS [expected FAIL] subtest: Cookie with %x7 in value is rejected (DOM).
- PASS [expected FAIL] subtest: Cookie with %x8 in value is rejected (DOM).
- PASS [expected FAIL] subtest: Cookie with %xa in value is rejected (DOM).
- And 22 more unexpected results...
TIMEOUT [expected OK] /credential-management/credentialscontainer-frame-basics.https.html (#39430)
- TIMEOUT [expected FAIL] subtest: navigator.credentials should be undefined in documents generated from data: URLs.
```
Test timed out
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 1
```
assert_equals: expected "80px" but got "41.45px"
```
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-serif (drawing text in a canvas)
OK /fetch/api/response/response-stream-with-broken-then.any.html (#35419)
- PASS [expected FAIL] subtest: Attempt to inject {done: false, value: bye} via Object.prototype.then.
- PASS [expected FAIL] subtest: Attempt to inject value: undefined via Object.prototype.then.
- PASS [expected FAIL] subtest: Attempt to inject undefined via Object.prototype.then.
- PASS [expected FAIL] subtest: Attempt to inject 8.2 via Object.prototype.then.
- PASS [expected FAIL] subtest: intercepting arraybuffer to text conversion via Object.prototype.then should not be possible
OK /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Cross-Site -> Same-Site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Origin -> Same Origin, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Origin -> Cross-Site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Site -> Cross-Site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-mode - attributes: crossorigin
- PASS [expected FAIL] subtest: sec-fetch-mode - attributes: crossorigin=use-credentials
OK /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-site destination, no attributes
- FAIL [expected PASS] subtest: sec-fetch-mode - Not sent to non-trustworthy same-origin destination, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-mode - Not sent to non-trustworthy same-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-mode - Not sent to non-trustworthy cross-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-dest - Not sent to non-trustworthy cross-site destination, no attributes
- FAIL [expected PASS] subtest: sec-fetch-user - Not sent to non-trustworthy cross-site destination, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
TIMEOUT [expected CRASH] /fetch/metadata/window-open.https.sub.html (#40339)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
```
assert_equals: expected "" but got "#fragment"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work.
```
Test timed out
```
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
- PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
- TIMEOUT [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
Test timed out
```
ERROR [expected OK] /html/semantics/embedded-content/media-elements/event_timeupdate_noautoplay.html (#25046)
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: 0x00 in name (formdata event)
- PASS [expected FAIL] subtest: multipart/form-data: 0x00 in value (normal form)
- PASS [expected FAIL] subtest: multipart/form-data: single quote in value (formdata event)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: 0x00 in name (normal form)
- PASS [expected FAIL] subtest: text/plain: 0x00 in value (formdata event)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: Basic File test (formdata event)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in value (normal form)
OK /preload/preload-error.sub.html (#37177)
- PASS [expected FAIL] subtest: success (fetch): main

OK [expected TIMEOUT] /preload/preload-resource-match.https.html (#38088)

FAIL [expected PASS] subtest: Loading style (same-origin) with link (same-origin) should reuse the preloaded response

assert_equals: https://web-platform.test:8443/preload/resources/echo-with-cors.py?type=text%2Fcss&amp;content=.cls%20%7B%20%7D&amp;uid=997f5480-cc05-4634-b084-1cf103ae0876&amp;5591acf5-7686-43d7-9c3b-df8583ec6dd2 expected 1 but got 2

FAIL [expected PASS] subtest: Loading style (no-cors) with link (no-cors) should reuse the preloaded response

assert_equals: https://www1.web-platform.test:8443/preload/resources/echo-with-cors.py?type=text%2Fcss&amp;content=.cls%20%7B%20%7D&amp;uid=997f5480-cc05-4634-b084-1cf103ae0876&amp;449ef201-b531-4ecb-9712-d244b60e059a expected 1 but got 2

FAIL [expected PASS] subtest: Loading style (anonymous) with link (anonymous) should reuse the preloaded response

assert_equals: https://www1.web-platform.test:8443/preload/resources/echo-with-cors.py?type=text%2Fcss&amp;content=.cls%20%7B%20%7D&amp;uid=997f5480-cc05-4634-b084-1cf103ae0876&amp;c4d6c579-5017-429b-ba68-22db7bcbffda expected 1 but got 2

PASS [expected TIMEOUT] subtest: Loading style (use-credentials) with link (anonymous) should discard the preloaded response

FAIL [expected NOTRUN] subtest: Loading style (use-credentials) with link (use-credentials) should reuse the preloaded response

assert_equals: https://www1.web-platform.test:8443/preload/resources/echo-with-cors.py?type=text%2Fcss&amp;content=.cls%20%7B%20%7D&amp;uid=997f5480-cc05-4634-b084-1cf103ae0876&amp;79aebeb1-4906-40e7-bcf9-fe5425e3824f expected 1 but got 2

TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- TIMEOUT [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
TIMEOUT /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.

github-actions · 2025-11-14T00:25:33Z

✨ Try run (#19349620182) succeeded.

mrobinson requested a review from gterzian as a code owner November 13, 2025 23:02

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 13, 2025

yezhizhen added the T-linux-wpt Do a try run of the WPT label Nov 13, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Nov 13, 2025

TimvdLippe approved these changes Nov 14, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 14, 2025

TimvdLippe added this pull request to the merge queue Nov 14, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 14, 2025

Merged via the queue into servo:main with commit 24daacf Nov 14, 2025
73 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

script: Issue resource timing for stylesheets before the "load" event #40618

script: Issue resource timing for stylesheets before the "load" event #40618

Uh oh!

mrobinson commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

script: Issue resource timing for stylesheets before the "load" event #40618

script: Issue resource timing for stylesheets before the "load" event #40618

Uh oh!

Conversation

mrobinson commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants