-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Implement protocol handler web API's behind flag #40616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#19339219739) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19339219739): Flaky unexpected result (36)
Stable unexpected results that are known to be intermittent (26)
Stable unexpected results (2)
|
|
|
11239ab to
2af3cc8
Compare
yezhizhen
requested changes
Nov 14, 2025
2af3cc8 to
4e017f7
Compare
yezhizhen
reviewed
Nov 14, 2025
This implements the web-facing API's behind a flag, where we further design the embedding API in a follow-up PR. It passes all relevant WPT tests, since the HTML specification leaves it up to user agents to determine when to process these protocol handlers. It also uses `once_cell` to lazily construct the regex, which is what the CSP crate also uses for its regexes [1]. Part of servo#40615 [1]: https://github.com/rust-ammonia/rust-content-security-policy/blob/db8f2e97fed57a6f903ee4f5e8109e5ed4c10141/src/lib.rs#L1550-L1569 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
4e017f7 to
9a74aff
Compare
yezhizhen
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the web-facing API's behind a flag, where we further design the embedding API in a
follow-up PR.
It passes all relevant WPT tests, since the HTML
specification leaves it up to user agents to
determine when to process these protocol handlers.
It also uses
once_cellto lazily construct theregex, which is what the CSP crate also uses for
its regexes 1.
Part of #40615