Skip to content

Conversation

@monissaJ
Copy link
Contributor

@monissaJ monissaJ commented Nov 7, 2025

Add webdriver based scripts to run scenario tests on OpenHarmony devices, with the purpose of testing functionality in CI. For now passing these tests will not be enforced, as we first need to see how reliable the CI tests are in daily usage.

Testing:
Functional and Performance Test Cases: Test that when new code is deployed, the Servo homepage and Mossel homepage load correctly; Mossel's navigation and swipe functions work properly.

@monissaJ monissaJ requested a review from sagudev as a code owner November 7, 2025 02:42
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 7, 2025
@jschwe jschwe self-requested a review November 7, 2025 06:48
commands_list = []
with open(file_name, 'r') as f:
for line in f.readlines():
if len(re.findall(r'org.servo.servo', line)) > 0 and len(re.findall(r'H:SendCommands', line)) > 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add a small comment explaining how the calculation works (what does H:SendCommands trace?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there are elements moving on the page, H: EndCommands will be printed to indicate that the frame is being sent out. After capturing the trace, the frame rate can be obtained by calculating the number of frames printed per unit time (per second).

@jschwe
Copy link
Member

jschwe commented Nov 7, 2025

You also should run ./mach test-tidy and check that there are no reported issues in the python code.
For formatting you should use ./mach fmt

@sagudev sagudev removed their request for review November 10, 2025 06:19
@servo-wpt-sync
Copy link
Collaborator

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

3 similar comments
@servo-wpt-sync
Copy link
Collaborator

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

@servo-wpt-sync
Copy link
Collaborator

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

@servo-wpt-sync
Copy link
Collaborator

🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync.

monissaJ and others added 17 commits November 19, 2025 21:18
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
The result step failed to detect failure.

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
monissaJ and others added 9 commits November 19, 2025 21:22
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: monissaJ <2362314605@qq.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
We use pyproject.toml now.

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
@jschwe
Copy link
Member

jschwe commented Nov 19, 2025

@jschwe jschwe changed the title add testcase: function test for servo ohos CI: Add webdriver based scenario tests Nov 19, 2025
@jschwe
Copy link
Member

jschwe commented Nov 19, 2025

I updated the description to better match the current status (e.g. framerate measuring is currently not added to CI, albeit already present in the scripts)

Copy link
Member

@jschwe jschwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I think we can merge this now, and continue iterating on the scripts afterwards.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 19, 2025
@jschwe jschwe added this pull request to the merge queue Nov 20, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 20, 2025
Merged via the queue into servo:main with commit 3dd145a Nov 20, 2025
35 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants