Skip to content

script: Implement export key operation of X25519 #40421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdm merged 3 commits into from
Nov 5, 2025
Merged

script: Implement export key operation of X25519 #40421

jdm merged 3 commits into from
Nov 5, 2025

Conversation

@kkoyung
Copy link
Member

@kkoyung kkoyung commented Nov 5, 2025

Continue on adding X25519 support to WebCrypto API. This patch implements export key operation of X25519, using X25519 implementation from the crate x25519-dalek.

Testing:

  • Pass some WPT tests that were expected to fail.
  • Some FAIL expectations are added. They require derive_bits operations of X25519, and RSA-OAEP, which have not yet implemented.

Fixes: Part of #39060

@kkoyung kkoyung requested a review from gterzian as a code owner November 5, 2025 05:16
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 5, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 5, 2025
@jdm jdm added this pull request to the merge queue Nov 5, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 5, 2025
@kkoyung kkoyung changed the title script: Implement import key operation of X25519 script: Implement export key operation of X25519 Nov 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 5, 2025
@servo-highfive servo-highfive added S-needs-rebase There are merge conflict errors. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 5, 2025
@kkoyung
Implement export key operation of X25519
6240735 
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
@kkoyung
Update WPT expectation for passed tests
fbb7c30 
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
@kkoyung
Update WPT expectation for new not-yet-passed tests
9c948d3 
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-rebase There are merge conflict errors. labels Nov 5, 2025
@kkoyung
Copy link
Member Author

kkoyung commented Nov 5, 2025

Rebased to resolve the merge conflict caused by simultaneously editing test meta data in tests/wpt/meta/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.https.any.js.ini in recent commit at main branch.

@jdm jdm enabled auto-merge November 5, 2025 07:32
@jdm jdm added this pull request to the merge queue Nov 5, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 5, 2025
Merged via the queue into servo:main with commit 22dcc10 Nov 5, 2025
35 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 5, 2025
@kkoyung kkoyung deleted the x25519-export branch November 7, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdm jdm jdm approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees

No one assigned

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kkoyung @jdm @servo-highfive