Skip to content

Add CanGc argument to SafeFromJSValConvertible::safe_from_jsval #40404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Taym95 merged 1 commit into from
Nov 4, 2025
Merged

Add CanGc argument to SafeFromJSValConvertible::safe_from_jsval #40404

Taym95 merged 1 commit into from
Nov 4, 2025

Conversation

@Taym95
Copy link
Member

@Taym95 Taym95 commented Nov 4, 2025

Add CanGc argument to SafeFromJSValConvertible::safe_from_jsval
Fixes: #40392

@Taym95 Taym95 requested a review from gterzian as a code owner November 4, 2025 17:12
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 4, 2025
@Taym95 Taym95 force-pushed the Add-CanGc-safe_from_jsval branch from 48423cf to 3eaecde Compare November 4, 2025 17:14
jdm
jdm approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 4, 2025
@jdm jdm added this pull request to the merge queue Nov 4, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 4, 2025
@servo-highfive servo-highfive added S-needs-rebase There are merge conflict errors. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 4, 2025
@Taym95 Taym95 force-pushed the Add-CanGc-safe_from_jsval branch from 3eaecde to fa8a7bf Compare November 4, 2025 19:59
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-rebase There are merge conflict errors. labels Nov 4, 2025
@Taym95 Taym95 enabled auto-merge November 4, 2025 19:59
@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 4, 2025
@Taym95
Add CanGc argument to SafeFromJSValConvertible::safe_from_jsval
f4b4e39 
Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
@Taym95 Taym95 force-pushed the Add-CanGc-safe_from_jsval branch from fa8a7bf to f4b4e39 Compare November 4, 2025 20:37
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Nov 4, 2025
@Taym95 Taym95 disabled auto-merge November 4, 2025 20:37
@Taym95 Taym95 enabled auto-merge November 4, 2025 20:37
@Taym95 Taym95 added this pull request to the merge queue Nov 4, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 4, 2025
Merged via the queue into servo:main with commit 6ec2425 Nov 4, 2025
35 checks passed
@Taym95 Taym95 deleted the Add-CanGc-safe_from_jsval branch November 4, 2025 21:19
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 4, 2025
@kkoyung kkoyung mentioned this pull request Nov 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdm jdm jdm approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees

No one assigned

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add CanGc argument to SafeFromJSValConvertible::safe_from_jsval

3 participants

@Taym95 @jdm @servo-highfive