libservo: Integrate context menu into the show_embedder_control API #40402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atbrakhi
approved these changes
Nov 4, 2025
d266fc4 to
182385d
Compare
182385d to
1d25b25
Compare
This PR integrates showing context menus into the `WebViewDelegate::show_embedder_control` API. In addition, `ContextMenuItem` and `ContextMenuAction` data types are exposed which abstract away the different components of the context menu. Later changes will implement this API for servoshell as well as add element-specific actions such as "Select All" and "Copy Image URL". Co-authored-by: atbrakhi <atbrakhi@igalia.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com>
1d25b25 to
2d41b31
Compare
|
🔨 Triggering try run (#19082277657) for OpenHarmony |
Bencher Report|
✨ Try run (#19082277657) succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates showing context menus into the
WebViewDelegate::show_embedder_controlAPI. In addition,ContextMenuItemandContextMenuActiondata types are exposed whichabstract away the different components of the context menu. Later
changes will implement this API for servoshell as well as add
element-specific actions such as "Select All" and "Copy Image URL".
Testing: This change adds a WebView API test.