script: Enforce exclusivity between <details> elements in the same tree #40314

simonwuelker · 2025-10-31T14:16:02Z

Within the same tree, only one <details> element with the same name may be open at a time. Before this change, this invariant was not enforced.

I've added a HashMap to Document and ShadowRoot which maps from a name to the a list of details elements with the same name. This map allows us to find conflicting details elements without having to traverse the whole tree. Of course this only works when the tree is a document tree or a shadow tree, so we still have to fall back to traverse_preorder in some cases (which I believe to be uncommon).

This is ready for review, but I'd like to wait until #40271 is merged to not cause unnecessary merge conflicts.

Testing: New web platform tests start to pass

github-actions · 2025-10-31T14:16:25Z

🔨 Triggering try run (#18975276824) for Linux (WPT)

github-actions · 2025-10-31T14:45:44Z

Test results for linux-wpt from try job (#18975276824):

Flaky unexpected result (12)

OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
OK /preload/preload-invalid-resources.html (#39091)
- PASS [expected FAIL] subtest: Preloading an invalid image (missing) should preload and not re-fetch
OK /trusted-types/trusted-types-navigation.html?21-25 (#38997)
- PASS [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in enforcing mode.
OK /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- PASS [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.

OK /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html (#22849)

FAIL [expected PASS] subtest: buffer-stitching-2

assert_approx_equals: Stitched sine‑wave buffers at sample rate 43800 sample[7824] |-12138368 - 0.3831769824028015| = 12138368.383176982 &gt; 0.0038986 expected 0.3831769824028015 +/- 0.0038986 but got -12138368

CRASH [expected OK] /websockets/unload-a-document/001.html?wss (#40072)
ERROR [expected OK] /workers/baseurl/alpha/import-in-moduleworker.html (#21315)

Stable unexpected results that are known to be intermittent (24)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
TIMEOUT [expected OK] /credential-management/credentialscontainer-frame-basics.https.html (#39430)
- TIMEOUT [expected FAIL] subtest: navigator.credentials should be undefined in documents generated from data: URLs.
```
Test timed out
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 1
```
assert_equals: expected "80px" but got "41.45px"
```
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 2
```
assert_equals: expected "80px" but got "41.45px"
```
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted serif (drawing text in a canvas)
```
assert_equals: quoted serif matches  @font-face rule expected 125 but got 40
```
TIMEOUT [expected FAIL] /dom/xslt/large-cdata.html (#38029)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-dest
- FAIL [expected PASS] subtest: sec-fetch-user
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- FAIL [expected PASS] subtest: Link with onclick navigation and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 1 (expected array [6, 3] got [6, 1])
```
OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
- PASS [expected FAIL] subtest: opener of discarded auxiliary browsing context
OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- TIMEOUT [expected FAIL] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
Test timed out
```
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
```
Test timed out
```
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- FAIL [expected TIMEOUT] subtest: Sandboxed iframe can not navigate other frame's popup
```
assert_equals: expected "cannot navigate" but got "can navigate"
```
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: Basic test (normal form)
CRASH [expected OK] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730, #39631)

OK /html/webappapis/user-prompts/print-during-unload.html (#35944)

FAIL [expected PASS] subtest: print() during unload

assert_array_equals: expected property 1 to be "destination" but got "error: window.print is not a function" (expected array ["start", "destination"] got ["start", "error: window.print is not a function"])

OK /preload/preload-error.sub.html (#37177)
- PASS [expected FAIL] subtest: success (fetch): main
- PASS [expected FAIL] subtest: CORS (fetch): main
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe

Stable unexpected results (2)

OK /html/dom/idlharness.https.html?include=HTML.+
- PASS [expected FAIL] subtest: HTMLDetailsElement interface: attribute name
- PASS [expected FAIL] subtest: HTMLDetailsElement interface: document.createElement("details") must inherit property "name" with the proper type
CRASH [expected OK] /html/semantics/interactive-elements/the-details-element/name-attribute.html

github-actions · 2025-10-31T14:45:57Z

⚠️ Try run (#18975276824) failed.

github-actions · 2025-10-31T15:18:37Z

🔨 Triggering try run (#18976979696) for Linux (WPT)

tests/wpt/meta/html/semantics/interactive-elements/the-details-element/name-attribute.html.ini

github-actions · 2025-10-31T15:43:58Z

Test results for linux-wpt from try job (#18976979696):

Flaky unexpected result (17)

OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- PASS [expected FAIL] subtest: WebGL test #45
- PASS [expected FAIL] subtest: WebGL test #47
- PASS [expected FAIL] subtest: WebGL test #49
- PASS [expected FAIL] subtest: WebGL test #51
- FAIL [expected PASS] subtest: WebGL test #53
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #55
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #57
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #59
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- PASS [expected FAIL] subtest: WebGL test #61
- PASS [expected FAIL] subtest: WebGL test #63
- And 10 more unexpected results...
OK /css/css-text/i18n/ja/css-text-line-break-ja-cpm-strict.html
- FAIL [expected PASS] subtest: 2049 EXCLAMATION QUESTION MARK may NOT appear at line start if ja and strict
```
assert_approx_equals: expected 99 +/- 1 but got 91
```
TIMEOUT [expected FAIL] /dom/xslt/encoding-single-chunk.html (#39983)
OK /fetch/content-length/api-and-duplicate-headers.any.worker.html (#35197)
- FAIL [expected PASS] subtest: fetch() and duplicate Content-Length/Content-Type headers
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- FAIL [expected PASS] subtest: Link with onclick navigation and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/009.html (#24456)
- PASS [expected FAIL] subtest: Link with onclick form submit to javascript url with document.write and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html (#39694)
- PASS [expected FAIL] subtest: Meta refresh is blocked by the allow-scripts sandbox flag at its creation time, not when refresh comes due
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- FAIL [expected PASS] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
```
uncaught exception: Error: assert_unreached: The iframe into which the meta was moved must not refresh Reached unreachable code
```
ERROR [expected OK] /html/semantics/embedded-content/media-elements/event_timeupdate_noautoplay.html (#25046)
OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)
- FAIL [expected PASS] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload
```
uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src" but got "about:blank"
```
OK /trusted-types/trusted-types-navigation.html?21-25 (#38997)
- PASS [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in enforcing mode.

Stable unexpected results that are known to be intermittent (22)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted serif (drawing text in a canvas)
```
assert_equals: quoted serif matches  @font-face rule expected 125 but got 40
```
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- FAIL [expected PASS] subtest: Single value - name is missing
```
assert_equals: expected "?name-pd1=value-pd1" but got ""
```
TIMEOUT [expected FAIL] /dom/xslt/large-cdata.html (#38029)
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-dest
- FAIL [expected PASS] subtest: sec-fetch-user
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Cross-site
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- PASS [expected FAIL] subtest: sec-fetch-site - Same origin, no options - registration
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- PASS [expected FAIL] subtest: Navigating to a different document with form submission
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
```
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
- TIMEOUT [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: Basic test (normal form)
- PASS [expected FAIL] subtest: multipart/form-data: 0x00 in value (normal form)
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task
```
Test timed out
```

OK /html/webappapis/user-prompts/print-during-unload.html (#35944)

FAIL [expected PASS] subtest: print() during unload

assert_array_equals: expected property 1 to be "destination" but got "error: window.print is not a function" (expected array ["start", "destination"] got ["start", "error: window.print is not a function"])

OK /preload/preload-error.sub.html (#37177)

PASS [expected FAIL] subtest: success (fetch): main

FAIL [expected PASS] subtest: 404 (fetch): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?pipe=status%28404%29&amp;label=fetch should be loaded expected a number greater than 0 but got 0

OK /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected FAIL] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.

github-actions · 2025-10-31T15:44:11Z

✨ Try run (#18976979696) succeeded.

lukewarlow · 2025-10-31T17:51:30Z

Does this account for situations when the details elements are nested but have the same name? I seem to recall that other browsers added handling for that. Perhaps that's not specced though?

simonwuelker · 2025-10-31T19:26:10Z

Does this account for situations when the details elements are nested but have the same name? I seem to recall that other browsers added handling for that. Perhaps that's not specced though?

I can't test it right now but I don't see why it wouldn't work with the current implementation. The details content is still in the same tree (even if its slotted in a internal shadow tree for <details>, and our implementation follows the recommended structure for internal <details>-shadow trees.

simonwuelker · 2025-10-31T22:55:27Z

<!DOCTYPE html>
<details id="outer" name="foo">
    <details id="inner" name="foo"></details>
</details>
<div id="host"></div>
<div id="container"></div>
<script>
let inner = document.getElementById("inner");
let outer = document.getElementById("outer");

outer.open = true;
inner.open = true;

console.log(outer.open);
console.log(inner.open);
</script>

This logs false and true, which matches both firefox and my understanding of the spec.

github-actions · 2025-11-03T02:24:13Z

🔨 Triggering try run (#19022088053) for Linux (WPT)

github-actions · 2025-11-03T02:52:05Z

Test results for linux-wpt from try job (#19022088053):

Flaky unexpected result (21)

OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
OK /IndexedDB/idbobjectstore_get.any.html (#38942)
- FAIL [expected PASS] subtest: Attempts to retrieve a record that doesn't exist
```
assert_unreached: unexpected open.success event Reached unreachable code
```
TIMEOUT [expected OK] /credential-management/credentialscontainer-frame-basics.https.html (#39430)
- TIMEOUT [expected FAIL] subtest: navigator.credentials should be undefined in documents generated from data: URLs.
```
Test timed out
```
TIMEOUT [expected FAIL] /dom/xslt/encoding-single-chunk.html (#39983)
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
TIMEOUT [expected CRASH] /html/anonymous-iframe/indexeddb.tentative.https.window.html (#39254)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
- PASS [expected FAIL] subtest: link click
- PASS [expected FAIL] subtest: form submission
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected OK] /html/browsers/the-window-object/open-close/open-features-non-integer-screeny.html
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
- PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
- TIMEOUT [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
Test timed out
```
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
OK /html/semantics/embedded-content/the-video-element/intrinsic_sizes.htm (#37173)
- FAIL [expected PASS] subtest: default object size after src is removed
```
assert_equals: expected "300px" but got "320px"
```
OK /preload/preload-xhr.html (#39092)
- FAIL [expected PASS] subtest: Make an XHR request immediately after creating link rel=preload.
```
assert_equals: resources/dummy.xml?token=e4192fe4-ec26-4236-bafe-0d97e6868504 expected 1 but got 0
```
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
CRASH [expected OK] /websockets/unload-a-document/001.html?default (#40080)
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)

Stable unexpected results that are known to be intermittent (18)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- PASS [expected FAIL] subtest: WebGL test #45
- PASS [expected FAIL] subtest: WebGL test #47
- PASS [expected FAIL] subtest: WebGL test #49
- PASS [expected FAIL] subtest: WebGL test #51
- FAIL [expected PASS] subtest: WebGL test #53
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #55
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #57
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #59
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- PASS [expected FAIL] subtest: WebGL test #61
- PASS [expected FAIL] subtest: WebGL test #63
- And 10 more unexpected results...
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- FAIL [expected PASS] subtest: Link with onclick navigation and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
- FAIL [expected PASS] subtest: Link with onclick form submit to javascript url and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- FAIL [expected PASS] subtest: Navigating to a different document with location.href
```
assert_equals: expected "http://web-platform.test:8000/common/blank.html?1" but got "about:blank"
```
- FAIL [expected PASS] subtest: Navigating to a different document with location.assign
```
assert_equals: expected "http://web-platform.test:8000/common/blank.html?1" but got "about:blank"
```
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730, #39631)
OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.worker.html (#33909)
- FAIL [expected PASS] subtest: Revoking a blob URL immediately after calling import will not fail
```
promise_test: Unhandled rejection with value: object "TypeError: Dynamic import failed"
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
- PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
- PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
OK /preload/preload-error.sub.html (#37177)
- PASS [expected FAIL] subtest: CORS (fetch): main
ERROR /service-workers/idlharness.https.any.html (#36250)
- PASS [expected TIMEOUT] subtest: ServiceWorkerContainer interface: operation register((TrustedScriptURL or USVString), optional RegistrationOptions)
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation enable()
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation disable()
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation setHeaderValue(ByteString)
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation getState()
OK /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- FAIL [expected PASS] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
OK /trusted-types/trusted-types-navigation.html?21-25 (#38997)
- PASS [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in enforcing mode.

github-actions · 2025-11-03T02:52:13Z

✨ Try run (#19022088053) succeeded.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

TimvdLippe

Some small comments, but overall LGTM!

TimvdLippe · 2025-11-04T18:37:53Z

components/script/dom/html/htmldetailselement.rs

+                document
+                    .details_name_groups()
+                    .unregister_details_element(old_name, self);
+                if matches!(mutation, AttributeMutation::Set(_)) {
+                    document
+                        .details_name_groups()
+                        .register_details_element(self);
+                }


Can we reduce duplication here by retrieving the relevant details_name_groups from the rootnode and then perform the steps? Given that both return RefMut, I would think that it should be possible to do that, is it not?

I don't think that will work because something has to be keeping the RefMut alive and that's either a shadow root or a document. I don't see a way to generalize here.

components/script/dom/html/htmldetailselement.rs

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

simonwuelker added the T-linux-wpt Do a try run of the WPT label Oct 31, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Oct 31, 2025

simonwuelker added the A-content/dom Interacting with the DOM from web content label Oct 31, 2025

simonwuelker added the T-linux-wpt Do a try run of the WPT label Oct 31, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Oct 31, 2025

simonwuelker commented Oct 31, 2025

View reviewed changes

tests/wpt/meta/html/semantics/interactive-elements/the-details-element/name-attribute.html.ini Outdated Show resolved Hide resolved

simonwuelker force-pushed the details-exclusivity branch from 6772938 to b3e7521 Compare October 31, 2025 15:28

simonwuelker marked this pull request as ready for review October 31, 2025 15:45

simonwuelker requested a review from gterzian as a code owner October 31, 2025 15:46

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 31, 2025

TimvdLippe mentioned this pull request Nov 2, 2025

script: Implement ToggleEvent and use for <details> element #40271

Merged

simonwuelker force-pushed the details-exclusivity branch from b3e7521 to 9b1a7d4 Compare November 3, 2025 02:22

simonwuelker added the T-linux-wpt Do a try run of the WPT label Nov 3, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Nov 3, 2025

simonwuelker added 4 commits November 4, 2025 14:10

script: Enforce exclusivity between <details> elements in the same tree

2191028

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

script: Don't bother to keep details name groups in tree order

9c59ddc

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

script: Handle name attribute changes on details elements

d1f3bcb

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

Update wpt expectations

0b38a60

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

simonwuelker force-pushed the details-exclusivity branch from 9b1a7d4 to 0b38a60 Compare November 4, 2025 13:10

TimvdLippe approved these changes Nov 4, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 4, 2025

jdm added the S-needs-code-changes Changes have not yet been made that were requested by a reviewer. label Nov 4, 2025

Address review comments

e54101a

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Nov 4, 2025

TimvdLippe added this pull request to the merge queue Nov 4, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 4, 2025

Merged via the queue into servo:main with commit 46e6d07 Nov 4, 2025
35 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 4, 2025

Uh oh!

script: Enforce exclusivity between <details> elements in the same tree #40314

script: Enforce exclusivity between <details> elements in the same tree #40314

Uh oh!

Conversation

simonwuelker commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

lukewarlow commented Oct 31, 2025

Uh oh!

simonwuelker commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simonwuelker commented Oct 31, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

TimvdLippe left a comment

Choose a reason for hiding this comment

Uh oh!

TimvdLippe Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

simonwuelker Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

simonwuelker commented Oct 31, 2025 •

edited

Loading

simonwuelker commented Oct 31, 2025 •

edited

Loading