Skip to content

script: Implement generate key operation of ECDH #40305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdm merged 2 commits into from
Oct 31, 2025
Merged

script: Implement generate key operation of ECDH #40305

jdm merged 2 commits into from
Oct 31, 2025

Conversation

@kkoyung
Copy link
Member

@kkoyung kkoyung commented Oct 31, 2025 •
edited
Loading

Continue on adding ECDH support to WebCrypto API. This patch implements generate key operation of ECDH.

Testing:

  • Pass some WPT tests that were expected to fail.
  • Some FAIL expectations are added. They require not-yet-implemented "derive bits" operation of ECDH. WPT skipped them when "generate key" operation for ECDH were not yet implemented.

Fixes: Part of #39060

@kkoyung
Implement generate key operation of ECDH
2b72edf 
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
@kkoyung
Update WPT expectation of passed tests
dbdb4cc 
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
@kkoyung kkoyung requested a review from gterzian as a code owner October 31, 2025 09:01
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 31, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 31, 2025
@jdm jdm added this pull request to the merge queue Oct 31, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 31, 2025
Merged via the queue into servo:main with commit 0ffc97e Oct 31, 2025
37 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 31, 2025
@kkoyung kkoyung deleted the ecdh-generate branch November 1, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdm jdm jdm approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kkoyung @jdm @servo-highfive