script: Mark document as unsalvageable if unclosed websockets present.#39940
Merged
yezhizhen merged 1 commit intoservo:mainfrom Oct 18, 2025
Merged
script: Mark document as unsalvageable if unclosed websockets present.#39940yezhizhen merged 1 commit intoservo:mainfrom
yezhizhen merged 1 commit intoservo:mainfrom
Conversation
This was referenced Oct 17, 2025
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our implementation of https://html.spec.whatwg.org/multipage/#unloading-document-cleanup-steps is incomplete and doesn't consider the existence of websockets. This change corrects that, and adds a little bit more structure to the current document unloading implementation.
Testing: New passing tests.
Fixes: #39872