Skip to content

script: Do not force push history handling.#39896

Merged
jdm merged 1 commit intoservo:mainfrom
jdm:no-push
Oct 15, 2025
Merged

script: Do not force push history handling.#39896
jdm merged 1 commit intoservo:mainfrom
jdm:no-push

Conversation

@jdm
Copy link
Member

@jdm jdm commented Oct 15, 2025

Steps 12 and 13 of https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigate contains logic to update the provided history handling mode when navigating, but there is no else clause in the specification. This change removes the logic in Servo that falls back to "push" mode if neither step is executed.

Testing: New WPT test added.
Fixes: #39818

@jdm jdm requested a review from gterzian as a code owner October 15, 2025 12:24
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 15, 2025
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@servo-wpt-sync
Copy link
Collaborator

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#55451) with upstreamable changes.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 15, 2025
@jdm jdm enabled auto-merge October 15, 2025 13:10
@jdm jdm added this pull request to the merge queue Oct 15, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 15, 2025
Merged via the queue into servo:main with commit 8476a78 Oct 15, 2025
28 checks passed
@jdm jdm deleted the no-push branch October 15, 2025 14:46
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navigation incorrectly defaults to history pushing in most cases

5 participants