-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add basic IDL implementation for LargestContentfulPaint
#39714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@shubhamg13 What's the status of this PR? |
I'm trying to reuse some of existing logic instead of duplicating. cc: @xiaochengh |
6efe741 to
f9cee81
Compare
35e86e8 to
73998e1
Compare
066d7f9 to
5f4bc3d
Compare
IDL implementation for LargestContentfulPaint
c96cead to
824bc81
Compare
|
🔨 Triggering try run (#19127870810) for Linux (WPT) |
38f8732 to
6e4623c
Compare
|
Test results for linux-wpt from try job (#19127870810): Flaky unexpected result (38)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (1)
|
|
|
|
Rerunning as the interface was just exposed. |
|
Test results for linux-wpt from try job (#19128523508): Flaky unexpected result (45)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (1)
|
|
|
|
@yezhizhen Can you re-run, coz it passed it here |
|
🔨 Triggering try run (#19130153858) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19130153858): Flaky unexpected result (39)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (1)
|
|
|
Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
|
🔨 Triggering try run (#19132414920) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19132414920): Flaky unexpected result (49)
Stable unexpected results that are known to be intermittent (26)
Stable unexpected results (1)
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
largest_contentful_paint_enabled is now just dangling preference. We should either remove them or keep things gated.
It is fine now, maybe it was something on server. Can you add it to merge queue again. @yezhizhen |
Add basic
IDLimplementation forLargestContentfulPaintTesting: Tested locally
Fixes: N/A