servoshell: Right-click menu #39291
Closed
servoshell: Right-click menu #39291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
fa0cef1 to
57e4c7b
Compare
mrobinson
reviewed
Sep 16, 2025
Comment on lines
+519
to
533
| fn show_native_context_menu( | ||
| &self, | ||
| _webview: WebView, | ||
| result_sender: GenericSender<ContextMenuResult>, | ||
| _: Option<String>, | ||
| _: Vec<String>, | ||
| _options: NativeContextMenu, | ||
| ) { | ||
| let _ = result_sender.send(ContextMenuResult::Ignored); | ||
| } | ||
|
|
||
| fn show_custom_context_menu( | ||
| &self, | ||
| _webview: WebView, | ||
| result_sender: GenericSender<ContextMenuResult>, | ||
| _items: Vec<ContextMenuItem>, | ||
| ) { |
Member
There was a problem hiding this comment.
What is the difference between a native and custom context menu?
Contributor
Author
There was a problem hiding this comment.
Native menu is the one the browser will display by default, with actions that can only be handled by the browser itself. Custom context menus are created by the script thread.
Contributor
Author
There was a problem hiding this comment.
On second thought, I'm considering removing that functionality.
| ), | ||
| /// Show a context menu to the user | ||
| ShowContextMenu( | ||
| ShowCustomContextMenu( |
mrobinson
requested changes
Sep 16, 2025
| libservo = { path = "../../components/servo", features = ["background_hang_monitor", "bluetooth", "testbinding"] } | ||
| log = { workspace = true } | ||
| mime_guess = { workspace = true } | ||
| muda = "0.17.1" |
Member
There was a problem hiding this comment.
I would prefer not to add another dependency, especially one that adds dependencies on platform-specific toolkits. Please implement these menus as egui context menus.
Member
|
This change has been superseded by recent work improving the Servo context menu APIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a righclick menu on desktop servoshell. At the moment, the rightclick menu displays completely disabled options when clicking on a link. Additionally custom rightclick menus aren't supported (I still need to clean up the API a bit).
Supports: windows and MacOS.
Testing: Manual
Fixes: Partially #38062