Throw `SyntaxError` from `Location::SetHref` #39051

arihant2math · 2025-08-31T07:38:07Z

It was originally throwing a TypeError, which was making WPT fail.

Testing: Many happy WPT subtests
Fixes: #39050

github-actions · 2025-08-31T07:39:02Z

🔨 Triggering try run (#17354206371) for Linux (WPT)

github-actions · 2025-08-31T08:01:33Z

Test results for linux-wpt from try job (#17354206371):

Flaky unexpected result (19)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
CRASH [expected TIMEOUT] /IndexedDB/crashtests/create-index.any.worker.html
OK /IndexedDB/delete-request-queue.any.html
- PASS [expected FAIL] subtest: Deletes are processed as a FIFO queue
OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
TIMEOUT [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/max-payload.tentative.https.window.html (#35210)
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/small-payload.tentative.https.window.html (#35210)
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- PASS [expected FAIL] subtest: Link with onclick navigation and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
- PASS [expected FAIL] subtest: Link with onclick form submit to javascript url and href navigation
TIMEOUT /html/browsers/history/the-history-interface/001.html (#12580)
- FAIL [expected PASS] subtest: traversing history must also traverse hash changes
```
assert_equals: (this could cause other failures later on) expected "" but got "test"
```
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected PASS] subtest: Non-HTMLElement should not support autofocus
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
- NOTRUN [expected TIMEOUT] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
- TIMEOUT [expected FAIL] subtest: Verifies that location navigations take precedence when following form submissions.
```
Test timed out
```
OK /intersection-observer/callback-cross-realm-report-exception.html (#38829)
- FAIL [expected PASS] subtest: IntersectionObserver reports the exception from its callback in the callback's global object
```
assert_array_equals: lengths differ, expected array ["frame1"] length 1, got [] length 0
```
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
OK /trusted-types/trusted-types-navigation.html?21-25 (#38997)
- PASS [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in enforcing mode.
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)

Stable unexpected results that are known to be intermittent (22)

FAIL [expected PASS] /_mozilla/css/stacked_layers.html (#15988)
FAIL [expected PASS] /_mozilla/gfx-rs-gecko/descriptor-ranges.html (#23258)
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 2
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted serif (drawing text in a canvas)
```
assert_equals: quoted serif matches  @font-face rule expected 125 but got 40
```
FAIL [expected PASS] /css/css-grid/grid-items/grid-auto-margin-and-replaced-item-001.html (#37162)
TIMEOUT [expected FAIL] /dom/xslt/large-cdata.html (#38029)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-dest
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 1 (expected array [6, 3] got [6, 1])
```
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
```
TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730)
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```

OK /preload/preload-error.sub.html (#37177)

FAIL [expected PASS] subtest: success (script): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.js?label=script should be loaded expected a number greater than 0 but got 0

PASS [expected FAIL] subtest: 404 (script): main
PASS [expected FAIL] subtest: success (xhr): main

FAIL [expected PASS] subtest: 404 (xhr): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?pipe=status%28404%29&amp;label=xhr should be loaded expected a number greater than 0 but got 0

PASS [expected FAIL] subtest: CORS (xhr): main
PASS [expected FAIL] subtest: Decode-error (style): main

FAIL [expected PASS] subtest: Decode-error (script): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?pipe=header%28Content-Type%2Ctext%2Fjavascript%29&amp;label=script should be loaded expected a number greater than 0 but got 0

TIMEOUT [expected CRASH] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- TIMEOUT [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
- NOTRUN [expected FAIL] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- PASS [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
- PASS [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- TIMEOUT [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
```
Test timed out
```
TIMEOUT [expected CRASH] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- FAIL [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```

Stable unexpected results (1)

OK /html/browsers/browsing-the-web/navigating-across-documents/navigate-to-unparseable-url.html
- PASS [expected FAIL] subtest: location.href setter throws a SyntaxError DOMException for unparseable URLs

github-actions · 2025-08-31T08:01:41Z

⚠️ Try run (#17354206371) failed.

github-actions · 2025-08-31T08:08:30Z

🔨 Triggering try run (#17354447941) for Linux (WPT)

components/script/dom/location.rs

sagudev · 2025-08-31T08:17:14Z

.../html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html.ini

This is intermittent failure: #29066, so I think we should remove expectations here.

components/script/dom/location.rs

github-actions · 2025-08-31T08:30:24Z

Test results for linux-wpt from try job (#17354447941):

Flaky unexpected result (21)

CRASH [expected TIMEOUT] /IndexedDB/crashtests/create-index.any.worker.html
OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
TIMEOUT /IndexedDB/idbobjectstore_delete.any.worker.html
- FAIL [expected PASS] subtest: delete() key doesn't match any records
```
assert_unreached: unexpected open.success event Reached unreachable code
```
CRASH [expected OK] /IndexedDB/nested-cloning-basic.any.worker.html (#38842)
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted serif (drawing text in a canvas)
```
assert_equals: quoted serif matches  @font-face rule expected 125 but got 40
```
OK /fetch/content-length/api-and-duplicate-headers.any.html (#35873)
- FAIL [expected PASS] subtest: fetch() and duplicate Content-Length/Content-Type headers
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /fetch/content-length/api-and-duplicate-headers.any.worker.html (#35197)
- FAIL [expected PASS] subtest: fetch() and duplicate Content-Length/Content-Type headers
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/009.html (#24456)
- FAIL [expected PASS] subtest: Link with onclick form submit to javascript url with document.write and href navigation
```
assert_array_equals: expected property 1 to be "href" but got "click" (expected array ["write", "href"] got ["write", "click"])
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
```
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 3 but got 2 (expected array [6, 3] got [6, 2])
```
CRASH [expected OK] /html/browsers/the-window-object/open-close/open-features-non-integer-left.html
TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```

OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)

FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler

assert_array_equals: expected property 1 to be "Script #1 ran" but got "Script #3 ran" (expected array ["Script #2 ran", "Script #1 ran", "Script #3 ran", "Script #4 ran"] got ["Script #2 ran", "Script #3 ran", "Script #4 ran", "Script #1 ran"])

OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.worker.html (#33909)
- FAIL [expected PASS] subtest: Revoking a blob URL immediately after calling import will not fail
```
promise_test: Unhandled rejection with value: object "TypeError: Dynamic import failed"
```
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
- TIMEOUT [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
- NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
ERROR /service-workers/idlharness.https.any.html (#36250)
- PASS [expected TIMEOUT] subtest: ServiceWorkerContainer interface: operation register((TrustedScriptURL or USVString), optional RegistrationOptions)
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation enable()
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation disable()
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation setHeaderValue(ByteString)
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation getState()
OK [expected TIMEOUT] /webmessaging/without-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)

Stable unexpected results that are known to be intermittent (27)

OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- PASS [expected FAIL] subtest: Revoke blob URL after calling fetch, fetch should succeed
FAIL [expected PASS] /_mozilla/css/stacked_layers.html (#15988)
FAIL [expected PASS] /_mozilla/gfx-rs-gecko/descriptor-ranges.html (#23258)
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```

OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)

PASS [expected FAIL] subtest: WebGL test #61
PASS [expected FAIL] subtest: WebGL test #63
PASS [expected FAIL] subtest: WebGL test #65
PASS [expected FAIL] subtest: WebGL test #67

FAIL [expected PASS] subtest: WebGL test #69

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #71

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

FAIL [expected PASS] subtest: WebGL test #73

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #75

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

TIMEOUT [expected FAIL] /dom/xslt/large-cdata.html (#38029)
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
- FAIL [expected PASS] subtest: Link with onclick form submit to javascript url and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored
```
assert_equals: expected "?pass" but got "?fail"
```

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

TIMEOUT /html/browsers/history/the-history-interface/001.html (#12580)
- FAIL [expected PASS] subtest: traversing history must also traverse hash changes
```
assert_equals: (this could cause other failures later on) expected "" but got "test"
```

OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)

FAIL [expected PASS] subtest: opener of discarded auxiliary browsing context

assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"

PASS [expected FAIL] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- FAIL [expected TIMEOUT] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work.
```
assert_not_equals: got disallowed value Element node &lt;body&gt;&lt;/body&gt;
```
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730)
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```

OK /preload/preload-error.sub.html (#37177)

PASS [expected FAIL] subtest: CORS (style): main

FAIL [expected PASS] subtest: success (script): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.js?label=script should be loaded expected a number greater than 0 but got 0

FAIL [expected PASS] subtest: Decode-error (script): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?pipe=header%28Content-Type%2Ctext%2Fjavascript%29&amp;label=script should be loaded expected a number greater than 0 but got 0

FAIL [expected PASS] subtest: MIME-error (script): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.css?pipe=header%28Content-Type%2Ctext%2Fnotjavascript%29&amp;label=script should be loaded expected a number greater than 0 but got 0

OK /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected FAIL] subtest: Navigate a window via anchor with javascript:-urls in enforcing mode.
TIMEOUT [expected CRASH] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- TIMEOUT [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
- NOTRUN [expected FAIL] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
OK /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- PASS [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
TIMEOUT [expected CRASH] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- FAIL [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```

github-actions · 2025-08-31T08:30:32Z

✨ Try run (#17354447941) succeeded.

Signed-off-by: Ashwin Naren <arihant2math@gmail.com>

Co-authored-by: Sam <16504129+sagudev@users.noreply.github.com> Signed-off-by: Ashwin Naren <arihant2math@gmail.com>

Signed-off-by: Ashwin Naren <arihant2math@gmail.com>

arihant2math requested a review from gterzian as a code owner August 31, 2025 07:38

arihant2math added the T-linux-wpt Do a try run of the WPT label Aug 31, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Aug 31, 2025

arihant2math added the T-linux-wpt Do a try run of the WPT label Aug 31, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Aug 31, 2025

sagudev reviewed Aug 31, 2025

View reviewed changes

components/script/dom/location.rs Outdated Show resolved Hide resolved

sagudev reviewed Aug 31, 2025

View reviewed changes

components/script/dom/location.rs Outdated Show resolved Hide resolved

arihant2math and others added 3 commits September 2, 2025 09:32

Throw SyntaxError from Location::SetHref

d466e34

Signed-off-by: Ashwin Naren <arihant2math@gmail.com>

update more expectations

399a893

Signed-off-by: Ashwin Naren <arihant2math@gmail.com>

Update components/script/dom/location.rs

6fe8944

Co-authored-by: Sam <16504129+sagudev@users.noreply.github.com> Signed-off-by: Ashwin Naren <arihant2math@gmail.com>

arihant2math force-pushed the fix-location-set-href branch from c96f79f to 6fe8944 Compare September 2, 2025 16:32

jdm approved these changes Sep 2, 2025

View reviewed changes

jdm enabled auto-merge September 2, 2025 16:34

Include error details in SyntaxError handling

1fb2462

Signed-off-by: Ashwin Naren <arihant2math@gmail.com>

auto-merge was automatically disabled September 2, 2025 16:42
Head branch was pushed to by a user without write access

jdm enabled auto-merge September 2, 2025 16:49

jdm added this pull request to the merge queue Sep 2, 2025

Merged via the queue into servo:main with commit b0b70ec Sep 2, 2025
22 checks passed

arihant2math deleted the fix-location-set-href branch September 2, 2025 20:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Throw `SyntaxError` from `Location::SetHref` #39051

Throw `SyntaxError` from `Location::SetHref` #39051

Uh oh!

arihant2math commented Aug 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

Uh oh!

sagudev Aug 31, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Throw SyntaxError from Location::SetHref #39051

Throw SyntaxError from Location::SetHref #39051

Uh oh!

Conversation

arihant2math commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

Uh oh!

sagudev Aug 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

github-actions bot commented Aug 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Throw `SyntaxError` from `Location::SetHref` #39051

Throw `SyntaxError` from `Location::SetHref` #39051

arihant2math commented Aug 31, 2025 •

edited

Loading