-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
script: Prepare to run script and callback before invoking CE constructor #39013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
script: Prepare to run script and callback before invoking CE constructor #39013
Conversation
|
🔨 Triggering try run (#17317787942) for Linux (WPT) |
|
Test results for linux-wpt from try job (#17317787942): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (3)
|
|
|
1655ae5 to
5d64d10
Compare
|
🔨 Triggering try run (#17322804508) for Linux (WPT) |
|
Test results for linux-wpt from try job (#17322804508): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (26)
Stable unexpected results (3)
|
|
|
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
9f83fa4 to
03fc173
Compare
|
🔨 Triggering try run (#18653423428) for Linux (WPT) |
|
Test results for linux-wpt from try job (#18653423428): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (25)
Stable unexpected results (3)
|
|
|
mrobinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. r+ with the test expectations updated.
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Additionally, this change adjusts the step numbers around the code because they were outdated.
Testing: ???
Fixes #39004
Probably fixes #32977