Skip to content

Conversation

@delan
Copy link
Member

@delan delan commented Aug 12, 2025

the Firefox devtools client often sends multiple getBreakpointListActor requests to the watcher actor when connecting, and the Firefox devtools server returns the same breakpoint list actor every time, but Servo returns a new breakpoint list actor each time. this patch aligns Servo’s behaviour with Firefox.

Testing: this patch adds a devtools test

@delan delan requested a review from atbrakhi August 12, 2025 10:49
@atbrakhi atbrakhi enabled auto-merge August 12, 2025 10:57
@delan delan changed the title devtools: Fix getBreakpointListActor handler in watcher actor devtools: Fix getBreakpointListActor handler in watcher actor Aug 12, 2025
Co-authored-by: atbrakhi <atbrakhi@igalia.com>
Signed-off-by: Delan Azabani <dazabani@igalia.com>
@delan delan force-pushed the fix-get-breakpoint-list-actor branch from 424ff20 to 2452026 Compare August 12, 2025 11:33
@atbrakhi atbrakhi added this pull request to the merge queue Aug 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2025
@jdm jdm added this pull request to the merge queue Aug 12, 2025
Merged via the queue into main with commit 319f4f0 Aug 12, 2025
21 checks passed
@jdm jdm deleted the fix-get-breakpoint-list-actor branch August 12, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants