Disable `masonry` and `subgrid` tests by nicoburns · Pull Request #38451 · servo/servo

nicoburns · 2025-08-04T10:45:03Z

This disables the css/css-grid/subgrid and css/css-grid/masonry subsuites. These tests test Subgrid (CSS Grid level 2) and Masonry layout, neither of which we currently implement in Servo.

Signed-off-by: Nico Burns <nico@nicoburns.com>

github-actions · 2025-08-04T10:48:44Z

🔨 Triggering try run (#16721041311) for Linux (WPT)

github-actions · 2025-08-04T11:09:52Z

Test results for linux-wpt from try job (#16721041311):

Flaky unexpected result (19)

OK /FileAPI/url/url-with-fetch.any.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
CRASH [expected FAIL] /css/css-lists/nested-marker-styling.html
OK /fetch/content-length/api-and-duplicate-headers.any.html (#35873)
- FAIL [expected PASS] subtest: fetch() and duplicate Content-Length/Content-Type headers
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/009.html (#24456)
- PASS [expected FAIL] subtest: Link with onclick form submit to javascript url with document.write and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-top.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with "top" fragments should work.
```
Test timed out
```
OK [expected TIMEOUT] /html/semantics/embedded-content/media-elements/playing-the-media-resource/loop-from-ended.tentative.html (#33778)
- FAIL [expected TIMEOUT] subtest: play() with loop set to true after playback ended
```
this argument is not a finite floating-point value
```
OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)
- FAIL [expected PASS] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload
```
uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src" but got "about:blank"
```
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
OK /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
- PASS [expected FAIL] subtest: Verifies that location navigations take precedence when following form submissions.
OK [expected TIMEOUT] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- PASS [expected TIMEOUT] subtest: reparent-form-during-planned-navigation-task
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported

OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)

FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler

assert_array_equals: expected property 1 to be "Script #1 ran" but got "Script #3 ran" (expected array ["Script #2 ran", "Script #1 ran", "Script #3 ran", "Script #4 ran"] got ["Script #2 ran", "Script #3 ran", "Script #4 ran", "Script #1 ran"])

OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
- PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
- PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
OK /xhr/open-url-multi-window-5.htm (#23360)
- FAIL [expected PASS] subtest: XMLHttpRequest: open() resolving URLs (multi-Window; 5)
```
assert_throws_dom: function "function() {client.open("GET", "...") }" did not throw
```

Stable unexpected results that are known to be intermittent (18)

FAIL [expected PASS] /_mozilla/css/stacked_layers.html (#15988)
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 2
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '501' should prefer '503 520' over '500'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
OK /css/cssom-view/elementsFromPoint-iframes.html (#38362)
- PASS [expected FAIL] subtest: elementsFromPoint on the root document for points in iframe elements
TIMEOUT [expected FAIL] /dom/xslt/large-cdata.html (#38029)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-dest
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Same site
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK /html/semantics/embedded-content/the-video-element/intrinsic_sizes.htm (#37173)
- PASS [expected FAIL] subtest: default object size after src is removed
OK /preload/prefetch-document.html (#37210)
- PASS [expected FAIL] subtest: different-site document prefetch with 'as=document' should not be consumed

OK /preload/preload-error.sub.html (#37177)

PASS [expected FAIL] subtest: CORS (style): main

FAIL [expected PASS] subtest: 404 (xhr): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?pipe=status%28404%29&amp;label=xhr should be loaded expected a number greater than 0 but got 0

OK /resize-observer/eventloop.html (#33599)
- PASS [expected FAIL] subtest: test0: multiple notifications inside same event loop
OK /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html (#22849)
- FAIL [expected PASS] subtest: X Stitched sine-wave buffers at sample rate 44100 does not equal [0,0.06264832615852356,0.12505052983760834,0.18696144223213196,0.24813786149024963,0.308339387178421,0.36732959747314453,0.4248766601085663,0.480754554271698,0.5347436666488647,0.5866320133209229,0.6362156271934509,0.6832997798919678,0.7276994585990906,0.7692402601242065,0.8077589869499207...] with an element-wise tolerance of {"absoluteThreshold":0.000090957,"relativeThreshold":0}. Index Actual Expected AbsError RelError Test threshold [15300] -7.7237864268255029e-27 -8.2017236948013306e-1 8.2017236948013306e-1 1.0000000000000000e+0 9.0957000000000003e-5 [15301] -2.1671967605912945e-12 -8.5440337657928467e-1 8.5440337657711751e-1 9.9999999999746358e-1 9.0957000000000003e-5 Max AbsError of 8.5440337657711751e-1 at index of 15301. Max RelError of 1.0000000000000000e+0 at index of 15300.
```
assert_true: expected true got false
```
- FAIL [expected PASS] subtest: X SNR (41.9644756054668 dB) is not greater than or equal to 85.58. Got 41.9644756054668.
```
assert_true: expected true got false
```
OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)

github-actions · 2025-08-04T11:10:01Z

✨ Try run (#16721041311) succeeded.

Loirooriol

I think leaving them enabled might help detecting crashes like #34948 (comment), but fine either way I guess.

nicoburns · 2025-08-24T18:24:57Z

On second thoughts, perhaps it is best to leave them enabled. I think it makes it easier to compare test results with other browsers.

Disable masonry and subgrid tests

075edfb

Signed-off-by: Nico Burns <nico@nicoburns.com>

nicoburns added A-testing A-layout/2020 https://github.com/servo/servo/wiki/Layout-2020 T-linux-wpt Do a try run of the WPT labels Aug 4, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Aug 4, 2025

nicoburns requested review from Loirooriol and mrobinson August 4, 2025 11:15

nicoburns mentioned this pull request Aug 4, 2025

Tracking issue: CSS Grid #34479

Open

20 tasks

Loirooriol approved these changes Aug 4, 2025

View reviewed changes

nicoburns closed this Aug 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Disable `masonry` and `subgrid` tests#38451

Disable `masonry` and `subgrid` tests#38451
nicoburns wants to merge 1 commit intoservo:mainfrom
nicoburns:disable-masonry-subgrid-tests

nicoburns commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

Loirooriol left a comment

Uh oh!

nicoburns commented Aug 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

nicoburns commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

Loirooriol left a comment

Choose a reason for hiding this comment

Uh oh!

nicoburns commented Aug 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants