htmlmediaelement: Make dirty element on any intrinsic size changes#37056
Merged
jdm merged 1 commit intoservo:mainfrom May 21, 2025
Merged
Conversation
Contributor
Author
Contributor
Author
|
cc @xiaochengh |
jdm
reviewed
May 20, 2025
c6f9705 to
06c020c
Compare
Contributor
Author
|
Linux WPT results (PASSED): https://github.com/tharkum/servo/actions/runs/15154968507 |
To properly compute (the video) element's content size for layout requires to dirty the element on any intrinstic size changes. Full list of the operations which cause layout invalidation: - media metadata update (NEW) - removing "src" attribute - video frame update - show poster image Fixes: servo#34434 Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>
06c020c to
acb3b5a
Compare
jdm
approved these changes
May 21, 2025
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To properly compute (the video) element's content size for
layout requires to dirty the element on any intrinstic size changes.
Full list of the operations which cause layout invalidation:
Testing: html/semantics/embedded-content/the-video-element/intrinsic_sizes.htm
Fixes: #34434