Merged
Conversation
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
sebsebmc
reviewed
May 10, 2025
| - name: Build (${{ inputs.profile }}) | ||
| run: | | ||
| ./mach build --use-crown --locked --${{ inputs.profile }} | ||
| ./mach build --use-crown --locked --${{ inputs.profile }} ${{ inputs.build-args }} |
Contributor
There was a problem hiding this comment.
Where are the build args going to come from? Are they just going to be statically defined in the workflows and this is just setting up the interesting for that? Im concerned about the risk of template injection here
Member
Author
There was a problem hiding this comment.
like all inputs, they will come from workflow call which populates args based on try_parser.py output. No injection should be possible (at least from non servo org members). But if it is possible it's already possible via other inputs (here it would be possible to abuse profile to get functionality of build-args).
mrobinson
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
build-argsinput in CI and try_parser job definition so we can pass own build args to./mach buildTesting: There are tests for try parser and I tested CI in my fork.
Fixes: partial fix #36823