devtools: Use webview_id as browser_id
#35956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atbrakhi
commented
Mar 13, 2025
3 tasks
e90e100 to
eb4e10a
Compare
delan
previously approved these changes
Mar 14, 2025
eb4e10a to
a067dbf
Compare
delan
reviewed
Mar 14, 2025
Member
delan
left a comment
There was a problem hiding this comment.
After working on top of these changes in #35971, I think renaming the fields to webview_id at the serde/struct boundary actually made things more confusing for me, because when dealing with devtools protocol concepts, I expected things to be named after what they’re called in the protocol.
I think it would be better to leave the field names as browser_id, but add doc comments saying they correspond to a webview, and derive the field values from the WebViewId index, just like how outer_window_id values are derived from the PipelineId index. What do you think?
not as confident anymore (see my last comment)
Signed-off-by: atbrakhi <atbrakhi@igalia.com>
Signed-off-by: atbrakhi <atbrakhi@igalia.com>
Signed-off-by: atbrakhi <atbrakhi@igalia.com>
a067dbf to
4f70ef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors DevTools to use
webview_idasbrowser_idThese changes do not affect the current behavior of the DevTools in Servo.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorswebview_idasbrowser_id#35953