dom: Implement `WritableStream` #34844

gterzian · 2025-01-06T09:54:30Z

Implement writable stream https://streams.spec.whatwg.org/#writablestream

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #___ (GitHub issue number if applicable)

There are tests for these changes OR
These changes do not require tests because ___

jdm · 2025-01-10T17:43:18Z

components/script/dom/writablestreamdefaultcontroller.rs

+        // Let state be stream.[[state]].
+
+        // Assert: state is not "closed" or "errored".
+        assert!(stream.is_errored() || stream.is_closed());


I think this is inverted from the intended check.

gterzian · 2025-01-30T10:50:27Z

Note to self, apply rooting pattern of #34194

github-actions · 2025-02-05T13:18:57Z

🔨 Triggering try run (#13158231151) for Linux (WPT)

github-actions · 2025-02-05T14:03:58Z

Test results for linux-wpt-layout-2020 from try job (#13158231151):

Flaky unexpected result (18)

OK /_mozilla/css/offset_properties_inline.html

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

TIMEOUT [expected FAIL] /css/css-fonts/font-display/font-display-preload.html (#35108)
FAIL [expected PASS] /css/css-fonts/font-face-local-not-family.html
FAIL [expected PASS] /css/css-fonts/font-palette-23.html

OK /css/css-grid/alignment/grid-content-alignment-with-abspos-001.html (#34339)

FAIL [expected PASS] subtest: .grid 1

assert_equals: 
&lt;div class="grid" data-expected-width="800" data-expected-height="600"&gt;
    &lt;div class="a" id="item" data-offset-x="329" data-offset-y="269" data-expected-width="142" data-expected-height="62" style="place-self: center;"&gt;&lt;/div&gt;
  &lt;/div&gt;
offsetLeft expected 329 but got 0

PASS [expected FAIL] /css/css-position/sticky/position-sticky-left-002.html (#35135)
PASS [expected FAIL] /css/selectors/invalidation/any-link-attribute-removal.html (#35054)
OK /encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-x-sjis.html?1-1000
- FAIL [expected PASS] subtest: U+80 � %80
```
assert_equals: expected "%80" but got ""
```
- FAIL [expected PASS] subtest: U+A5 ¥ %5C
```
str is undefined
```
- FAIL [expected PASS] subtest: U+A7 § %81%98
```
str is undefined
```
- FAIL [expected PASS] subtest: U+A8 ¨ %81%4E
```
str is undefined
```
- FAIL [expected PASS] subtest: U+B0 ° %81%8B
```
str is undefined
```
- FAIL [expected PASS] subtest: U+B1 ± %81%7D
```
str is undefined
```
- FAIL [expected PASS] subtest: U+B4 ´ %81%4C
```
str is undefined
```
- FAIL [expected PASS] subtest: U+B6 ¶ %81%F7
```
str is undefined
```
- FAIL [expected PASS] subtest: U+D7 × %81%7E
```
str is undefined
```
- FAIL [expected PASS] subtest: U+F7 ÷ %81%80
```
str is undefined
```
- And 390 more unexpected results...
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-dest
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Same site
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- FAIL [expected PASS] subtest: Check execution order from nested timeout
```
assert_equals: Expected nested setTimeout to run second expected true but got false
```
- FAIL [expected PASS] subtest: Check execution order on load handler
```
assert_equals: Expected onload to run first expected false but got true
```
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
PASS [expected FAIL] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
CRASH [expected OK] /html/canvas/offscreen/canvas-host/2d.canvas.host.size.large.worker.html (#30164)

OK /html/semantics/forms/form-submission-0/form-data-set-usv.html (#34934)

FAIL [expected PASS] subtest: Strings from form controls should be converted to Unicode scalar values in form submission

assert_equals: expected "69 6e 70 75 74 31 ef bf bd 3d 69 6e 70 75 74 31 ef bf bd 0d 0a 69 6e 70 75 74 32 ef bf bd 3d 69 6e 70 75 74 32 ef bf bd 0d 0a 69 6e 70 75 74 33 ef bf bd 3d 69 6e 70 75 74 33 ef bf bd 0d 0a 69 6e 70 75 74 34 ef bf bd 3d 69 6e 70 75 74 34 ef bf bd 0d 0a" but got "\n  \n  \n    option\n  \n  \n  \n\n\n\n\"use strict\";\n\nconst form = document.querySelector(\"form\");\n\nfor (let el of Array.from(form.querySelectorAll(\"input\"))) { // Firefox/Edge support\n  el.name = el.id + \"\\uDC01\";\n  el.value = el.id + \"\\uDC01\";\n}\n\nconst select = document.querySelector(\"select\");\nselect.name = select.id + \"\\uDC01\";\nselect.firstElementChild.value = select.id + \"\\uDC01\";\n\n"

OK /resize-observer/change-layout-in-error.html (#32629)
- PASS [expected FAIL] subtest: Changing layout in window error handler should not result in lifecyle loop when resize observer loop limit is reached.
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
OK /xhr/send-redirect.htm (#32026)
- FAIL [expected PASS] subtest: XMLHttpRequest: send() - Redirects (basics) (303 does redirect)
```
assert_equals: expected (string) "GET" but got (object) null
```

Stable unexpected results that are known to be intermittent (12)

OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
FAIL [expected PASS] /css/compositing/mix-blend-mode/mix-blend-mode-video-sibling.html (#32849)
ERROR [expected OK] /fetch/fetch-later/quota/same-origin-iframe/empty-payload.tentative.https.window.html (#35176)
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/oversized-payload.tentative.https.window.html (#35210)
OK /html/browsers/browsing-the-web/navigating-across-documents/009.html (#24456)
- FAIL [expected PASS] subtest: Link with onclick form submit to javascript url with document.write and href navigation
```
assert_array_equals: expected property 1 to be "href" but got "click" (expected array ["write", "href"] got ["write", "click"])
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
PASS [expected FAIL] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
TIMEOUT /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/semantics/forms/historical.html (#28568)
- FAIL [expected PASS] subtest: <input name=isindex> should not be supported
```
assert_regexp_match: expected object "/\?isindex=x$/" but got "about:blank"
```

Stable unexpected results (4)

OK /_mozilla/mozilla/interfaces.https.html

FAIL [expected PASS] subtest: Interfaces exposed on the window

assert_true: If this is failing: DANGER, are you sure you want to expose the new interface WritableStreamDefaultController to all webpages as a property on the global? expected true got false

OK /_mozilla/mozilla/interfaces.worker.html

FAIL [expected PASS] subtest: interfaces

assert_true: If this is failing: DANGER, are you sure you want to expose the new interface WritableStreamDefaultController to all webpages as a property on the global? expected true got false

OK [expected ERROR] /encoding/streams/realms.window.html
- FAIL [expected PASS] subtest: a TextEncoderStream object should be associated with the realm the constructor came from
```
promise_test: Unhandled rejection with value: object "TypeError: obj is undefined"
```
- FAIL [expected PASS] subtest: TextEncoderStream's readable and writable attributes should come from the same realm as the constructor definition
```
promise_test: Unhandled rejection with value: object "TypeError: methodRealm[classname] is undefined"
```
- FAIL [expected PASS] subtest: the output chunks when read is called after write should come from the same realm as the constructor of TextEncoderStream
```
promise_test: Unhandled rejection with value: object "TypeError: result is undefined"
```
- FAIL [expected PASS] subtest: the output chunks when write is called with a pending read should come from the same realm as the constructor of TextEncoderStream
```
promise_test: Unhandled rejection with value: object "TypeError: result is undefined"
```
- FAIL [expected PASS] subtest: TypeError for unconvertable chunk should come from constructor realm of TextEncoderStream
```
assert_unreached: Should have rejected: write TypeError should come from constructor realm Reached unreachable code
```
- FAIL [expected PASS] subtest: a TextDecoderStream object should be associated with the realm the constructor came from
```
promise_test: Unhandled rejection with value: object "TypeError: obj is undefined"
```
- FAIL [expected PASS] subtest: TextDecoderStream's readable and writable attributes should come from the same realm as the constructor definition
```
promise_test: Unhandled rejection with value: object "TypeError: methodRealm[classname] is undefined"
```
- FAIL [expected PASS] subtest: the result object when read is called after write should come from the same realm as the constructor of TextDecoderStream
```
promise_test: Unhandled rejection with value: object "TypeError: result is undefined"
```
- FAIL [expected PASS] subtest: the result object when write is called with a pending read should come from the same realm as the constructor of TextDecoderStream
```
promise_test: Unhandled rejection with value: object "TypeError: result is undefined"
```
- FAIL [expected PASS] subtest: TypeError for chunk with the wrong type should come from constructor realm of TextDecoderStream
```
assert_unreached: Should have rejected: write TypeError should come from constructor realm Reached unreachable code
```
- And 2 more unexpected results...
OK /workers/semantics/interface-objects/001.worker.html
- PASS [expected FAIL] subtest: The WritableStream interface object should be exposed.

github-actions · 2025-02-05T14:05:47Z

⚠️ Try run (#13158231151) failed.

github-actions · 2025-02-06T10:52:22Z

🔨 Triggering try run (#13177174020) for Linux (WPT)