Raf delivery: run rafs for all pipeline if tick received for any. by gterzian · Pull Request #33395 · servo/servo

gterzian · 2024-09-10T10:16:17Z

The first commits ensures the ordering of running rafs between parent and child docs, by running rafs for all pipeline if a tick was received for any(see #33251).

The second commits prevents a sequence of "update the rendering" tasks from running one after the other and starving other script tasks(see #33395 (comment)).

For the first commit there is a TLA spec modelling the idea at https://gist.github.com/gterzian/1f297aa22393ea8604ad14ca6a5cfff6

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Fix Running Animation Frame Callbacks #33251 and fix Intermittent PASS in /html/webappapis/update-rendering/child-document-raf-order.html #33028 (GitHub issue number if applicable)

There are tests for these changes OR
These changes do not require tests because ___

github-actions · 2024-09-10T10:16:57Z

🔨 Triggering try run (#10790452232) for Linux WPT

github-actions · 2024-09-10T10:59:51Z

⚠️ Try run (#10790452232) failed.

github-actions · 2024-09-10T12:06:10Z

🔨 Triggering try run (#10792054606) for Linux WPT

github-actions · 2024-09-10T13:14:02Z

Test results for linux-wpt-layout-2020 from try job (#10792054606):

Flaky unexpected result (15)

FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
OK /_mozilla/mozilla/task_queue_throttling.any.html (#22519)
- FAIL [expected PASS] subtest: Throttling the performance timeline task queue.
```
assert_true: expected true got false
```
TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
PASS [expected FAIL] /css/css-position/sticky/position-sticky-change-top.html (#33139)
FAIL [expected PASS] /css/css-values/vh_not_refreshing_on_chrome.html (#23385, #15570)
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-origin destination, no attributes
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: Basic test (normal form)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in value (normal form)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: \r\n in name (normal form)
OK /html/webappapis/update-rendering/child-document-raf-order.html (#33028)
- PASS [expected FAIL] subtest: Ordering of steps in "Update the Rendering" - child document requestAnimationFrame order
ERROR [expected OK] /workers/semantics/run-a-worker/003.html (#22765)

Stable unexpected results that are known to be intermittent (13)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '501' should prefer '450 460' over '390 410'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
OK /css/cssom-view/MediaQueryList-addListener-handleEvent.html (#24571)
- FAIL [expected PASS] subtest: looks up handleEvent method on every event dispatch
```
assert_equals: expected 1 but got 0
```
OK /css/cssom-view/MediaQueryList-extends-EventTarget-interop.html (#25285)
- FAIL [expected PASS] subtest: listener added with addListener and addEventListener (capture) is called twice
```
assert_equals: triggerMQLEvent expected 2 but got 0
```
OK /css/cssom-view/MediaQueryListEvent.html (#25275)
- PASS [expected FAIL] subtest: argument of addListener
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
TIMEOUT /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: 0x00 in name (formdata event)
- PASS [expected FAIL] subtest: text/plain: 0x00 in filename (formdata event)
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
```
assert_true: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
```
assert_true: Reload domContentLoadedEventStart &gt; Original domContentLoadedEventStart expected true got false
```
- FAIL [expected PASS] subtest: Reload fetchStart > Original fetchStart
```
assert_true: Reload fetchStart &gt; Original fetchStart expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```
OK /resize-observer/change-layout-in-error.html (#32629)
- PASS [expected FAIL] subtest: Changing layout in window error handler should not result in lifecyle loop when resize observer loop limit is reached.
OK [expected TIMEOUT] /resource-timing/nested-context-navigations-iframe.html (#24311)
- PASS [expected NOTRUN] subtest: Test that iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that crossorigin iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that cross-site iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that iframe refreshes are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that cross-site iframe refreshes are not observable by the parent
OK /workers/WorkerGlobalScope-close.html (#23064)
- PASS [expected FAIL] subtest: Test sending a message after closing.
ERROR [expected OK] /workers/constructors/Worker/Worker-constructor.html (#22991)

github-actions · 2024-09-10T13:14:14Z

✨ Try run (#10792054606) succeeded.

github-actions · 2024-09-10T13:17:04Z

🔨 Triggering try run (#10793278423) for Linux WPT

github-actions · 2024-09-10T13:52:03Z

Test results for linux-wpt-layout-2020 from try job (#10793278423):

Flaky unexpected result (22)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
- NOTRUN [expected PASS] subtest: Overall test
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 21deg' should prefer 'oblique -50deg -20deg' over 'oblique -40deg -30deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
OK /css/css-values/calc-in-media-queries-with-mixed-units.html (#31731)
- FAIL [expected PASS] subtest: box should be orange if the calc between vh+px in @media was correct
```
assert_equals: expected "rgb(255, 165, 0)" but got "rgb(0, 0, 255)"
```

OK /css/css-values/cap-invalidation.html (#32757)

FAIL [expected PASS] subtest: CSS Values and Units Test: cap invalidation

uncaught exception: Error: assert_not_equals: expect the capital height of Ahem and sans-serif to be different got disallowed value 371.3333333333333

OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-user
OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
- FAIL [expected PASS] subtest: 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "A" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿ" but got ""
```
- FAIL [expected PASS] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked
```
assert_equals: expected "�ÿĀ" but got ""
```
- FAIL [expected PASS] subtest: D83D DE0D set in href="" targeting a frame and clicked
```
assert_equals: expected "😍" but got ""
```
- FAIL [expected PASS] subtest: DE0D 0041 set in href="" targeting a frame and clicked
```
assert_equals: expected "\ufffdA" but got ""
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation lengths differ, expected array [6, 5] length 2, got [6, 3, 3] length 3
```
TIMEOUT [expected PASS] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html (#32745)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work.
```
Test timed out
```
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: double quote in name (normal form)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: double quote in filename (formdata event)
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
- PASS [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
- PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts

OK /html/webappapis/update-rendering/child-document-raf-order.html (#33028)

FAIL [expected PASS] subtest: Ordering of steps in "Update the Rendering" - child document requestAnimationFrame order

assert_array_equals: expected order of notifications lengths differ, expected array ["parent_raf", "first_child_raf", "second_child_raf"] length 3, got […, "first_child_raf", "second_child_raf", "parent_raf", "first_child_raf", "second_child_raf", "parent_raf", "first_child_raf", "second_child_raf", "parent_raf", "first_child_raf", "second_child_raf", "parent_raf", "first_child_raf", "second_child_raf", "parent_raf", "first_child_raf", "second_child_raf", "parent_raf", "first_child_raf", "second_child_raf"] length 24

TIMEOUT [expected OK] /webmessaging/with-ports/018.html (#24485)
- TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:
```
Test timed out
```
OK /workers/WorkerGlobalScope-close.html (#23064)
- PASS [expected FAIL] subtest: Test sending a message after closing.

Stable unexpected results that are known to be intermittent (11)

FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
- PASS [expected FAIL] subtest: listeners are called correct number of times
OK /css/cssom-view/MediaQueryList-extends-EventTarget-interop.html (#25285)
- PASS [expected FAIL] subtest: capturing event listener fires before non-capturing listener at target
OK /css/cssom-view/MediaQueryListEvent.html (#25275)
- PASS [expected FAIL] subtest: argument of addListener
TIMEOUT [expected ERROR] /html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args.html (#32745)
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
- FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```
OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
- TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task
```
Test timed out
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
```
assert_true: Reload domContentLoadedEventStart &gt; Original domContentLoadedEventStart expected true got false
```
- FAIL [expected PASS] subtest: Reload fetchStart > Original fetchStart
```
assert_true: Reload fetchStart &gt; Original fetchStart expected true got false
```
OK [expected TIMEOUT] /resource-timing/nested-context-navigations-iframe.html (#24311)
- PASS [expected NOTRUN] subtest: Test that iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that crossorigin iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that cross-site iframe navigations are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that iframe refreshes are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that crossorigin iframe refreshes are not observable by the parent
- PASS [expected NOTRUN] subtest: Test that cross-site iframe refreshes are not observable by the parent
ERROR [expected OK] /webxr/render_state_update.https.html (#27535)

github-actions · 2024-09-10T13:52:17Z

✨ Try run (#10793278423) succeeded.

gterzian · 2024-09-11T10:29:58Z

Interesting

assert_array_equals: expected order of notifications lengths differ, expected array ["parent_raf", "first_child_raf", "second_child_raf"] length 3, got […, "first_child_raf", "second_child_raf", "parent_raf", "first_child_raf", "second_child_raf", "parent_raf", "first_child_raf", "second_child_raf", "parent_raf", "first_child_raf", "second_child_raf", "parent_raf", "first_child_raf", "second_child_raf", "parent_raf", "first_child_raf", "second_child_raf", "parent_raf", "first_child_raf", "second_child_raf"] length 24

gterzian · 2024-09-11T11:39:08Z

Interesting

I think this can happen because the test recursively requests rafs:

servo/tests/wpt/tests/html/webappapis/update-rendering/child-document-raf-order.html

Line 90 in cbc9304

// Request another notification to help ensure we're getting expected behavior.

and we prioritize the "update the rendering task" versus other tasks, including the timeout used to signal that the test is finished.

So this can result in many runs of the prioritized update the rendering task until finally the script-thread runs the sequential timeout.

Will try to address in a commit.

github-actions · 2024-09-11T11:46:54Z

🔨 Triggering try run (#10810966797) for Linux WPT

github-actions · 2024-09-11T12:10:07Z

Test results for linux-wpt-layout-2020 from try job (#10810966797):

Flaky unexpected result (17)

TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '500' should prefer '500' over '450 460'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 40deg 50deg' over 'oblique 5deg 10deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 5deg' over 'normal'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 20deg' should prefer 'oblique 10deg' over 'italic'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
- FAIL [expected PASS] subtest: Matching font-style: 'oblique 0deg' should prefer 'oblique 5deg' over 'oblique 15deg 20deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
FAIL [expected PASS] /css/css-values/vh_not_refreshing_on_chrome.html (#23385, #15570)
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - name is missing
- PASS [expected FAIL] subtest: Null value should submit nothing
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
```
Test timed out
```
TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-origin destination, no attributes
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html (#32745)

ERROR /html/semantics/embedded-content/image-maps/image-map-processing-model/hash-name-reference.html (#16179)