Update to Rust1.80.0#32889
Closed
Hmikihiro wants to merge 9 commits intoservo:mainfrom
Hmikihiro:update-rust1.80.0
Closed
Update to Rust1.80.0#32889Hmikihiro wants to merge 9 commits intoservo:mainfrom Hmikihiro:update-rust1.80.0
Hmikihiro wants to merge 9 commits intoservo:mainfrom
Hmikihiro:update-rust1.80.0
Conversation
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
rust-lang/rust#124047 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
rust-lang/rust#123016 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
rust-lang/rust#124955 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
rust-lang/rust#125410 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
|
🔨 Triggering try run (#10163579470) for Linux WPT, MacOS, Windows, Android, OpenHarmony |
|
Test results for linux-wpt-layout-2013 from try job (#10163579470): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (16)
Stable unexpected results (71)
|
|
Test results for linux-wpt-layout-2020 from try job (#10163579470): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (15)
|
|
|
sagudev
reviewed
Jul 30, 2024
Member
sagudev
left a comment
There was a problem hiding this comment.
LGTM, commits have great messages, but there are some formatting changes I am not sure of (although tidy is happy?)
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustc library had some changes in 1.79 & 1.80.
LazyLockis part of standard library in 1.80Rust1.80 can replace from
lazy_static&once_cell::sync::Lazytostd::LazyLock.I would suggest updating to rust1.80 as the first step, with replace to
LazyLocklater../mach build -ddoes not report any errors./mach test-tidydoes not report any errors