Skip to content

Skip all flaky tests in performance-timeline/not-restored-reasons#32241

Closed
syvb wants to merge 1 commit intoservo:mainfrom
syvb:skip-all-not-restored-reasons
Closed

Skip all flaky tests in performance-timeline/not-restored-reasons#32241
syvb wants to merge 1 commit intoservo:mainfrom
syvb:skip-all-not-restored-reasons

Conversation

@syvb
Copy link
Contributor

@syvb syvb commented May 7, 2024

Skips all of the performance-timeline/not-restored-reasons tests. There are already issues for #32226 and #32213, but it seems #31361 made all of these tests flaky.

  • ./mach test-tidy does not report any errors
  • These changes do not require tests because they remove tests

@syvb syvb changed the title tSkip all flaky tests in performance-timeline/not-restored-reasons Skip all flaky tests in performance-timeline/not-restored-reasons May 7, 2024
@sagudev
Copy link
Member

sagudev commented May 7, 2024

There is also /fetch/fetch-later/send-on-deactivate.tentative.https.window.html, although maybe we should just revert #31361 an bake it a little more (before all those test were FAIL now, they are flaky TIMEOUT/FAIL, so there isn't anything that would be missing).

@mrobinson
Copy link
Member

mrobinson commented May 7, 2024

There is also /fetch/fetch-later/send-on-deactivate.tentative.https.window.html, although maybe we should just revert #31361 an bake it a little more (before all those test were FAIL now, they are flaky TIMEOUT/FAIL, so there isn't anything that would be missing).

It does sound like we should revert #31361 if it made an entire directory of tests flaky.

@mukilan
Copy link
Member

mukilan commented May 7, 2024

The /html/browsers/browsing-the-web/remote-context-helper-tests/navigation-bfcache.window.html test has also failed in the following two runs and seems related to the BFCache
https://github.com/servo/servo/runs/24648485771
https://github.com/servo/servo/runs/24654937105

I'm in favor of reverting #31361

@sagudev sagudev mentioned this pull request May 7, 2024
Merged
@syvb syvb closed this May 8, 2024
@syvb syvb deleted the skip-all-not-restored-reasons branch May 8, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@syvb @sagudev @mrobinson @mukilan