Use dynamic dispatch in mozjs::panic::wrap_panic
#26642
Conversation
Pick up servo/rust-mozjs#512 Fixes #26585 This diff is best viewed with "ignore whitespace changes", because of indentation change.
|
Heads up! This PR modifies the following files:
|
|
|
Manishearth
left a comment
There was a problem hiding this comment.
seems good, r=me pending jdm's perf investigation
we could also potentially make it a cfg to use dynamic dispatch here, if there is a small but nontrivial perf impact
jdm
left a comment
There was a problem hiding this comment.
I've verified that performance stays the same on the majority of the demos at https://servo.org/hl-home/. We may be slightly slower at flinging balls as fast as possible in ballshooter, and the particles might also be slightly slower, but both of those were also within the realm of measurement error, so I'm not particularly concerned.
|
servo/rust-mozjs#512 has landed @bors-servo r=Manishearth |
|
📌 Commit d103e06 has been approved by |
|
☀️ Test successful - status-taskcluster |
Pick up servo/rust-mozjs#512
Fixes #26585
This diff is best viewed with "ignore whitespace changes", because of indentation change.