Check the BHM option before starting it in multi-process mode.#26106
Merged
bors-servo merged 1 commit intoservo:masterfrom Apr 4, 2020
Merged
Check the BHM option before starting it in multi-process mode.#26106bors-servo merged 1 commit intoservo:masterfrom
bors-servo merged 1 commit intoservo:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon. |
gterzian
reviewed
Apr 4, 2020
components/servo/lib.rs
Outdated
| background_hang_monitor_register, | ||
| None, | ||
| ); | ||
| if opts::get().background_hang_monitor { |
Member
There was a problem hiding this comment.
It might be clearer to do something like:
let background_hang_monitor_register = if opts::get().background_hang_monitor {
unprivileged_content.register_with_background_hang_monitor()
} else {
None
};
gterzian
requested changes
Apr 4, 2020
Member
gterzian
left a comment
There was a problem hiding this comment.
Thanks for the contribution, looks like the solution is right, with a small stylistic suggestion...
cf73462 to
8b9390d
Compare
gterzian
approved these changes
Apr 4, 2020
Member
gterzian
left a comment
There was a problem hiding this comment.
Looks good, and thanks for the contribution!
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit 8b9390d has been approved by |
Contributor
Contributor
|
☀️ Test successful - status-taskcluster |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multi-process mode, if the BHM option is set start with one otherwise don't.
I didn't add a test for this. However if I should I'd be happy to be pointed to where similar tests are done (meaning tests of options yielding the expected state) because I didn't find my way in all those tests.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThese changes fix Check for Background-Hang-Monitor opts in multi-process #26088
There are tests for these changes OR
These changes do not require tests because they are minor enough to not require one.